Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
golang-dev
Home
+ new post
About this group
Join this group
code review 6442114: cmd/6g, cmd/8g: eliminate short integer arithmetic when... (issue 6442114)
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   3 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
remyoudomph...@gmail.com  
View profile  
 More options Aug 11 2012, 8:15 am
From: remyoudomph...@gmail.com
Date: Sat, 11 Aug 2012 12:15:43 +0000
Local: Sat, Aug 11 2012 8:15 am
Subject: code review 6442114: cmd/6g, cmd/8g: eliminate short integer arithmetic when... (issue 6442114)
Print | Individual message | Show original | Report this message | Find messages by this author
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

Description:
cmd/6g, cmd/8g: eliminate short integer arithmetic when possible.

Fixes issue 3909.
Fixes issue 3910.

Please review this at http://codereview.appspot.com/6442114/

Affected files:
   M src/cmd/6g/peep.c
   M src/cmd/8g/gsubr.c
   M src/cmd/8g/peep.c
   M test/fixedbugs/bug440_32.go
   M test/fixedbugs/bug440_64.go


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
remyoudomph...@gmail.com  
View profile  
 More options Aug 11 2012, 8:22 am
From: remyoudomph...@gmail.com
Date: Sat, 11 Aug 2012 12:22:46 +0000
Local: Sat, Aug 11 2012 8:22 am
Subject: Re: code review 6442114: cmd/6g, cmd/8g: eliminate short integer arithmetic when... (issue 6442114)
Print | Individual message | Show original | Report this message | Find messages by this author
This patch intends to replace CL 6446088 and CL 6459046 by eliminating
short integer instructions whenever possible. It passes the tests but
can cause more issues: there were some with the carry bit (needc is not
complete) and a use of ORB with arguments being actual ints and not
bytes (in the uint64 -> float64 conversion).

http://codereview.appspot.com/6442114/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
nigel...@golang.org  
View profile  
 More options Aug 13 2012, 3:36 am
From: nigel...@golang.org
Date: Mon, 13 Aug 2012 07:36:26 +0000
Local: Mon, Aug 13 2012 3:36 am
Subject: Re: code review 6442114: cmd/6g, cmd/8g: eliminate short integer arithmetic when... (issue 6442114)
Print | Individual message | Show original | Report this message | Find messages by this author

http://codereview.appspot.com/6442114/diff/7001/src/cmd/6g/peep.c
File src/cmd/6g/peep.c (right):

http://codereview.appspot.com/6442114/diff/7001/src/cmd/6g/peep.c#new...
src/cmd/6g/peep.c:139: // byte, word arithmetic elimination.
s/spaces/tabs/. Similarly on the next line.

http://codereview.appspot.com/6442114/diff/7001/src/cmd/8g/peep.c
File src/cmd/8g/peep.c (right):

http://codereview.appspot.com/6442114/diff/7001/src/cmd/8g/peep.c#new...
src/cmd/8g/peep.c:133: // byte, word arithmetic elimination.
s/spaces/tabs/.

http://codereview.appspot.com/6442114/diff/7001/test/fixedbugs/bug440...
File test/fixedbugs/bug440_64.go (right):

http://codereview.appspot.com/6442114/diff/7001/test/fixedbugs/bug440...
test/fixedbugs/bug440_64.go:1: // run
Dumb question: is this file new? Why don't I see it in my tree?

http://codereview.appspot.com/6442114/diff/7001/test/fixedbugs/bug440...
test/fixedbugs/bug440_64.go:4: // about 64- vs 64-bit moves during
splitContractIndex.
"64- vs 64-bit" makes no sense.

http://codereview.appspot.com/6442114/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google