Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
code review 6495114: bytes, strings: faster Fields (issue 6495114)
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
r...@golang.org  
View profile  
 More options Sep 21 2012, 5:03 am
From: r...@golang.org
Date: Fri, 21 Sep 2012 09:03:35 +0000
Local: Fri, Sep 21 2012 5:03 am
Subject: Re: code review 6495114: bytes, strings: faster Fields (issue 6495114)
do you have the updated version?

http://codereview.appspot.com/6495114/diff/8001/src/pkg/bytes/bytes.go
File src/pkg/bytes/bytes.go (right):

http://codereview.appspot.com/6495114/diff/8001/src/pkg/bytes/bytes.g...
src/pkg/bytes/bytes.go:303: if c < 0x80 {
utf8.RuneSelf

http://codereview.appspot.com/6495114/diff/8001/src/pkg/bytes/bytes.g...
src/pkg/bytes/bytes.go:327: if c < 0x80 {
utf8.RuneSelf

http://codereview.appspot.com/6495114/diff/8001/src/pkg/strings/strin...
File src/pkg/strings/strings.go (right):

http://codereview.appspot.com/6495114/diff/8001/src/pkg/strings/strin...
src/pkg/strings/strings.go:283: if c < 0x80 {
utf8.RuneSelf

http://codereview.appspot.com/6495114/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Russ Cox  
View profile  
 More options Sep 21 2012, 10:37 am
From: Russ Cox <r...@golang.org>
Date: Fri, 21 Sep 2012 10:37:58 -0400
Local: Fri, Sep 21 2012 10:37 am
Subject: Re: code review 6495114: bytes, strings: faster Fields (issue 6495114)

On Fri, Sep 21, 2012 at 5:03 AM,  <r...@golang.org> wrote:
> do you have the updated version?

No, not yet. I am still thinking about what the right resizing
strategy is. I can make the code much faster on the benchmark by
estimating the new array size based on fields/byte processed so far,
cutting out almost all reallocations, but that gives it the chance to
wildly overestimate and overallocate what it would otherwise need. The
current code, while slower by being two passes, at least does not
overallocate. I'm still not quite sure how to balance those. Probably
I will give up that particular speedup and go back to ordinary append.

Russ


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »