code review 5901044: windows: install fixes (issue 5901044)
The group you are posting to is a
Usenet group . Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
From:
jdpoir... @gmail.com Date: Sat, 24 Mar 2012 22:23:55 +0000
Local: Sat, Mar 24 2012 6:23 pm
Subject: code review 5901044: windows: install fixes (issue 5901044)
Reviewers: golang-dev_googlegroups.com,
Message:
I'd like you to review this change to https://go.googlecode.com/hg/
Description:
* set default installation drive to C:\
Please review this at http://codereview.appspot.com/5901044/
Affected files:
Index: misc/dist/windows/installer.wxs
<CustomAction
<!-- Programs Menu Shortcuts -->
<!-- Registry & Environment Settings -->
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
Brad Fitzpatrick <bradf... @golang.org> Date: Sat, 24 Mar 2012 16:25:10 -0700
Local: Sat, Mar 24 2012 7:25 pm
Subject: Re: [golang-dev] code review 5901044: windows: install fixes (issue 5901044)
What's the result of not setting the default to C:\ ? What else would it
On Sat, Mar 24, 2012 at 3:23 PM, <jdpoir
... @gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
> Message:
> I'd like you to review this change to https://go.googlecode.com/hg/
> Description:
> * set default installation drive to C:\
> Please review this at http://codereview.appspot.com/**5901044/ <http://codereview.appspot.com/5901044/ >
> Affected files:
> Index: misc/dist/windows/installer.**wxs
> <CustomAction
> <!-- Programs Menu Shortcuts -->
> <!-- Registry & Environment Settings -->
You must
Sign in before you can post messages.
You do not have the permission required to post.
Date: Sat, 24 Mar 2012 23:32:06 +0000
Local: Sat, Mar 24 2012 7:32 pm
Subject: Re: code review 5901044: windows: install fixes (issue 5901044)
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
jdpoir... @gmail.com Date: Sun, 25 Mar 2012 00:10:33 +0000
Local: Sat, Mar 24 2012 8:10 pm
Subject: Re: code review 5901044: windows: install fixes (issue 5901044)
On 2012/03/24 23:25:10, bradfitz wrote:
> LGTM
It's not always the system drive, and I'm not sure how it decides.
http://codereview.appspot.com/5901044/
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
jdpoir... @gmail.com Date: Sun, 25 Mar 2012 00:10:48 +0000
Local: Sat, Mar 24 2012 8:10 pm
Subject: Re: code review 5901044: windows: install fixes (issue 5901044)
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
jdpoir... @gmail.com Date: Sun, 25 Mar 2012 00:56:26 +0000
Local: Sat, Mar 24 2012 8:56 pm
Subject: Re: code review 5901044: windows: install fixes (issue 5901044)
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
Brad Fitzpatrick <bradf... @golang.org> Date: Sat, 24 Mar 2012 17:59:40 -0700
Local: Sat, Mar 24 2012 8:59 pm
Subject: Re: code review 5901044: windows: install fixes (issue 5901044)
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
Joseph Poirier <jdpoir... @gmail.com> Date: Sat, 24 Mar 2012 20:58:06 -0500
Local: Sat, Mar 24 2012 9:58 pm
Subject: Re: code review 5901044: windows: install fixes (issue 5901044)
On Sat, Mar 24, 2012 at 7:59 PM, Brad Fitzpatrick <bradf
... @golang.org> wrote:
> Sorry, I assumed you'd already tested this when I LGTM'd.
Sorry, I'm not setup for the amd64 builds. BTW, what's the setup
you're using to make the amd64 releases?
-joe
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
Brad Fitzpatrick <bradf... @golang.org> Date: Sat, 24 Mar 2012 19:07:14 -0700
Local: Sat, Mar 24 2012 10:07 pm
Subject: Re: code review 5901044: windows: install fixes (issue 5901044)
On Sat, Mar 24, 2012 at 6:58 PM, Joseph Poirier <jdpoir
... @gmail.com> wrote:
> On Sat, Mar 24, 2012 at 7:59 PM, Brad Fitzpatrick <bradf
... @golang.org>
> wrote:
> > Sorry, I assumed you'd already tested this when I LGTM'd.
> Sorry, I'm not setup for the amd64 builds. BTW, what's the setup
A 64-bit Windows VM on Rackspace. (We use Amazon for 32-bit, and Rackspace
for 64-bit, because previously Amazon didn't have cheap 64-bit instances
available, but they do in the past ~month...)
It's Windows 2003 Datacenter Edition, IIRC, whatever that means.
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
Joseph Poirier <jdpoir... @gmail.com> Date: Sat, 24 Mar 2012 22:04:18 -0500
Local: Sat, Mar 24 2012 11:04 pm
Subject: Re: code review 5901044: windows: install fixes (issue 5901044)
On Sat, Mar 24, 2012 at 9:07 PM, Brad Fitzpatrick <bradf
... @golang.org> wrote:
> On Sat, Mar 24, 2012 at 6:58 PM, Joseph Poirier <jdpoir... @gmail.com> wrote:
>> On Sat, Mar 24, 2012 at 7:59 PM, Brad Fitzpatrick <bradf... @golang.org>
>> Sorry, I'm not setup for the amd64 builds. BTW, what's the setup
> A 64-bit Windows VM on Rackspace. (We use Amazon for 32-bit, and Rackspace
> It's Windows 2003 Datacenter Edition, IIRC, whatever that means.
What MinGW/GCC are you using?
I'm running a 64-bit Windows 7 with a standard MinGW/GCC setup and I
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
Joseph Poirier <jdpoir... @gmail.com> Date: Sat, 24 Mar 2012 22:37:31 -0500
Local: Sat, Mar 24 2012 11:37 pm
Subject: Re: code review 5901044: windows: install fixes (issue 5901044)
On Sat, Mar 24, 2012 at 10:04 PM, Joseph Poirier <jdpoir
... @gmail.com> wrote:
> On Sat, Mar 24, 2012 at 9:07 PM, Brad Fitzpatrick <bradf
... @golang.org> wrote:
> What MinGW/GCC are you using?
> I'm running a 64-bit Windows 7 with a standard MinGW/GCC setup and I
I downloaded the MinGW64 that (I think) Alex put together. I was able
to build the installer and everything seems to be working.
I did get some missing file errors during the file harvest stage of
I'm making modifications to installer.wxs locally then cloning tip and
> bindist -repo="C:\Go" -tag=tip -upload=false -v=true windows-amd64
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
Andrew Gerrand <a... @golang.org> Date: Mon, 26 Mar 2012 16:47:53 +1100
Local: Mon, Mar 26 2012 1:47 am
Subject: Re: [golang-dev] code review 5901044: windows: install fixes (issue 5901044)
LGTM
Tested on windows-amd64.
You must
Sign in before you can post messages.
You do not have the permission required to post.
Date: Mon, 26 Mar 2012 05:48:25 +0000
Local: Mon, Mar 26 2012 1:48 am
Subject: Re: code review 5901044: windows: install fixes (issue 5901044)
You must
Sign in before you can post messages.
You do not have the permission required to post.
