code review 8934043: net: deflake raw IP protocol entry test on Windows (issue 8934043)

[mikioh...@gmail.com]

Reviewers: golang-dev1,

Message:
Hello golan...@googlegroups.com (cc: golan...@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
net: deflake raw IP protocol entry test on Windows

Update issue 5344.

Please review this at https://codereview.appspot.com/8934043/

Affected files:
M src/pkg/net/ipraw_test.go


Index: src/pkg/net/ipraw_test.go
===================================================================
--- a/src/pkg/net/ipraw_test.go
+++ b/src/pkg/net/ipraw_test.go
@@ -55,9 +55,8 @@
for _, tt := range resolveIPAddrTests {
addr, err := ResolveIPAddr(tt.net, tt.litAddr)
if err != tt.err {
- t.Fatalf("ResolveIPAddr(%v, %v) failed: %v", tt.net, tt.litAddr, err)
- }
- if !reflect.DeepEqual(addr, tt.addr) {
+ condFatalf(t, "ResolveIPAddr(%v, %v) failed: %v", tt.net, tt.litAddr,
err)
+ } else if !reflect.DeepEqual(addr, tt.addr) {
t.Fatalf("got %#v; expected %#v", addr, tt.addr)
}
}

[da...@cheney.net]

LGTM. Thank you. Please wait for brainman to confirm, and r for
permission to submit.

https://codereview.appspot.com/8934043/

[r...@golang.org]

LGTM

https://codereview.appspot.com/8934043/

[alex.b...@gmail.com]

LGTM

https://codereview.appspot.com/8934043/

[mikioh...@gmail.com]

*** Submitted as
https://code.google.com/p/go/source/detail?r=0c16e97c7587 ***

net: deflake raw IP protocol entry test on Windows

Update issue 5344

R=golang-dev, dave, r, alex.brainman
CC=golang-dev
https://codereview.appspot.com/8934043


https://codereview.appspot.com/8934043/