bug#12203: 24.1.50; *grep* buffer for grep over TRAMP contains shell prompt

[Matt McClure]

This bug report will be sent to the Bug-GNU-Emacs mailing list
and the GNU bug tracker at debbugs.gnu.org. Please check that
the From: line contains a valid email address. After a delay of up
to one day, you should receive an acknowledgement at that address.

Please write in English if possible, as the Emacs maintainers
usually do not have translators for other languages.

Please describe exactly what actions triggered the bug, and
the precise symptoms of the bug. If you can, give a recipe
starting from `emacs -Q':

***

When I use `M-x grep` in a TRAMP directory, the output in the `*grep*`
buffer contains the remote shell prompt.

For example, on my Mac, I can reproduce with:

open -n -a Emacs --args -Q --no-site-file --eval '(progn
(find-file "/vag...@192.168.33.3:/") (grep "grep -n -e vagrant
/etc/passwd"))'

Then the `*grep*` contains:

-*- mode: grep; default-directory: "/scpc:vag...@192.168.33.3:/" -*-
Grep started at Tue Aug 14 13:29:06

grep -n -e vagrant /etc/passwd /dev/null
[vagrant@vagrant-centos-5-8 ~]$
/etc/passwd:21:vagrant:x:500:500:Vagrant User:/home/vagrant:/bin/bash

Grep finished (matches found) at Tue Aug 14 13:29:10

I'd like to visit the buffer corresponding to the first match, but RET
on that line prompts me for a file to look, presumably because of the
prompt polluting the beginning of the line.

***

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
`bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/Applications/Emacs.app/Contents/Resources/etc/DEBUG.


In GNU Emacs 24.1.50.1 (x86_64-apple-darwin, NS apple-appkit-1038.36)
of 2012-07-14 on bob.porkrind.org
Bzr revision: 109087 c...@gnu.org-20120714053223-jxkxt958pqg8tisb
Windowing system distributor `Apple', version 10.3.1138
Configured using:
`configure '--host=x86_64-apple-darwin' '--build=i686-apple-darwin'
'--with-ns' 'build_alias=i686-apple-darwin'
'host_alias=x86_64-apple-darwin' 'CC=gcc -mmacosx-version-min=10.5''

Important settings:
value of $LANG: en_US.UTF-8
locale-coding-system: utf-8-unix
default enable-multibyte-characters: t

Major mode: Dired by name

Minor modes in effect:
shell-dirtrack-mode: t
tooltip-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t

Recent input:
<escape> x r e p o r t <tab> <return>

Recent messages:
Tramp: Opening connection for vag...@192.168.33.3 using scpc...done
ls does not support --dired; see `dired-use-ls-dired' for more details.
Tramp: Opening connection for vag...@192.168.33.3 using scpc...
Tramp: Sending command `exec ssh -q -l vagrant -o
ControlPath=/var/folders/vk/p95wm1qx0vdf0087p0z9qzc40000gn/T/tramp.39462dfg.%r@%h:%p
-o ControlMaster=yes -e none 192.168.33.3'

Tramp: Waiting for prompts from remote shell
Tramp: Sending command `exec ssh -q -l vagrant -o
ControlPath=/var/folders/vk/p95wm1qx0vdf0087p0z9qzc40000gn/T/tramp.39462dfg.%r@%h:%p
-o ControlMaster=yes -e none 192.168.33.3'
Tramp: Found remote shell prompt on `192.168.33.3'
Tramp: Opening connection for vag...@192.168.33.3 using scpc...done
Grep finished (matches found)

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rfc822 mml easymenu mml-sec
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mail-utils grep compile
dired tramp-cache tramp-sh tramp tramp-compat auth-source eieio byte-opt
bytecomp byte-compile cconv macroexp gnus-util mm-util mail-prsvr
password-cache tramp-loaddefs shell pcomplete comint ansi-color ring
format-spec advice help-fns advice-preload time-date tooltip ediff-hook
vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image
regexp-opt fringe tabulated-list newcomment lisp-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs
button faces cus-face files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process ns multi-tty emacs)


--
Matt McClure
http://www.matthewlmcclure.com
http://www.mapmyfitness.com/profile/matthewlmcclure

[Michael Albinus]

Matt McClure <matthew...@gmail.com> writes:

> When I use `M-x grep` in a TRAMP directory, the output in the `*grep*`
> buffer contains the remote shell prompt.

I could reproduce it locally, thanks for the report. An ill-minded
(narrow-region) ... (widen) sequence seems to be guilty.

I'll debug it further, when time pressure (@work) will decrease. There's
no simple fix, because some `start-file-process' invocations do
appreciate a prompt. Maybe we shall check, whether the process is still
alive. If it isn't, the prompt should be suppressed.

> Matt McClure

Best regards, Michael.

[Matt McClure]

On Wed, Aug 15, 2012 at 9:14 AM, Michael Albinus <michael...@gmx.de> wrote:
> Matt McClure <matthew...@gmail.com> writes:
>
>> When I use `M-x grep` in a TRAMP directory, the output in the `*grep*`
>> buffer contains the remote shell prompt.
>

> There's
> no simple fix, because some `start-file-process' invocations do
> appreciate a prompt. Maybe we shall check, whether the process is still
> alive. If it isn't, the prompt should be suppressed.

In case it's an easier change, if there were a newline after the
prompt it wouldn't break navigation to the first match.

[Michael Albinus]

Matt McClure <matthew...@gmail.com> writes:

>> There's no simple fix, because some `start-file-process' invocations
>> do appreciate a prompt. Maybe we shall check, whether the process is
>> still alive. If it isn't, the prompt should be suppressed.
>
> In case it's an easier change, if there were a newline after the
> prompt it wouldn't break navigation to the first match.

That could help for grep. But there are other use cases like "M-x shell",
which require a proper prompt.

I'm looking for a general solution.

Best regards, Michael.

[Michael Albinus]

Michael Albinus <michael...@gmx.de> writes:

>> When I use `M-x grep` in a TRAMP directory, the output in the `*grep*`
>> buffer contains the remote shell prompt.
>

> I could reproduce it locally, thanks for the report. An ill-minded
> (narrow-region) ... (widen) sequence seems to be guilty.

I have committed a fix to the trunk; could you, please, test?

[Matt McClure]

On Fri, Aug 17, 2012 at 5:26 AM, Michael Albinus <michael...@gmx.de> wrote:
> I have committed a fix to the trunk; could you, please, test?

Sure thing. It looks like your change is in revision 109657, so I'll
wait for the next Mac build.

[Michael Albinus]

Matt McClure <matthew...@gmail.com> writes:

Hi Matt,

>> I have committed a fix to the trunk; could you, please, test?
>
> Sure thing. It looks like your change is in revision 109657, so I'll
> wait for the next Mac build.

This bug is still open. Could you test it meanwhile?

Best regards, Michael.

[Matt McClure]

Michael,

Works for me. Sorry for the feedback delay.

Best,
Matt

[Michael Albinus]

Matt McClure <matthew...@gmail.com> writes:

> Michael,

Hi Matt,

> Works for me. Sorry for the feedback delay.

No problem, I just wanted to be sure that it works for you as well.

Closing the bug.

> Best,
> Matt

Best regards, Michael.