bug#14399: octave-mode bug

[Leo Liu]

I have written to octave's maintainers' list:
http://article.gmane.org/gmane.comp.gnu.octave.maintainers/32441

Leo

[Leo Liu]

Hi Stefan,

On 2013-05-15 20:00 +0800, Leo Liu wrote:
> http://article.gmane.org/gmane.comp.gnu.octave.maintainers/32441

It seems the octave community's consensus is: ... should not introduce
extra indentation in (), [] or {}. Could you help fix this bug?

Leo

[Leo Liu]

On 2013-05-18 07:13 +0800, Leo Liu wrote:
> It seems the octave community's consensus is: ... should not introduce
> extra indentation in (), [] or {}. Could you help fix this bug?

Hi Stefan,

I am unfamiliar with smie. I have been meaning to understand it but
haven't found time to. Could you help fix this indentation bug?

Leo

[Stefan Monnier]

> I am unfamiliar with smie. I have been meaning to understand it but
> haven't found time to. Could you help fix this indentation bug?

I can't remember much of the syntax of Octave. What does ";..." mean?


Stefan

[Rüdiger Sonderfeld]

... introduces a continuation line. Similar to \ in other languages.

a = [ foo;...
bar ]

is the same as a = [ foo; bar ].

See (info "(octave) Continuation Lines")

Regards,
Rüdiger

[Rüdiger Sonderfeld]

[Stefan Monnier]

>> > I am unfamiliar with smie. I have been meaning to understand it but
>> > haven't found time to. Could you help fix this indentation bug?
>> I can't remember much of the syntax of Octave. What does ";..." mean?
> ... introduces a continuation line. Similar to \ in other languages.

> a = [ foo;...
> bar ]

> is the same as a = [ foo; bar ].

That's the part I knew already ;-)

But in which way is

a = [ foo;...
bar ]

different from

a = [ foo
bar ]
or
a = [ foo;
bar ]

-- Stefan

[Stefan Monnier]

[Stefan Monnier]

Ping?

[Achim Gratz]

Stefan Monnier writes:
> That's the part I knew already ;-)
>
> But in which way is
>
> a = [ foo;...
> bar ]
>
> different from
>
> a = [ foo
> bar ]
> or
> a = [ foo;
> bar ]

For these three examples there is no difference because the newlines and
whitespace the continuation marker gobbles up wouldn't terminate or
alter the statement. On the other hand

a = [ foo ...
bar ]

_is_ different (introducing another column rather than a row).


Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

[Stefan Monnier]

>> That's the part I knew already ;-)
>>
>> But in which way is
>>
>> a = [ foo;...
>> bar ]
>>
>> different from
>>
>> a = [ foo
>> bar ]
>> or
>> a = [ foo;
>> bar ]

> For these three examples there is no difference because the newlines and
> whitespace the continuation marker gobbles up wouldn't terminate or
> alter the statement.

Thanks. So it begs the question: why would someone write

a = [ foo;...
bar ]

instead of one of the other two? I'm trying to understand what's the
intention behind it, to better understand how the code should behave.


Stefan

[Rüdiger Sonderfeld]

On Saturday 30 November 2013 12:19:30 Stefan Monnier wrote:
> Thanks. So it begs the question: why would someone write
>
> a = [ foo;...
> bar ]
>
> instead of one of the other two? I'm trying to understand what's the
> intention behind it, to better understand how the code should behave.

I think it's just a matter of style. I thought it had something to do with
Matlab compatibility but a quick test showed that Matlab accepts both forms as
well.

Regards,
Rüdiger

[Rüdiger Sonderfeld]

[Stefan Monnier]

>> It seems the octave community's consensus is: ... should not introduce

>> extra indentation in (), [] or {}. Could you help fix this bug?

> I am unfamiliar with smie. I have been meaning to understand it but
> haven't found time to. Could you help fix this indentation bug?

Looks like we've all been pretty dumb: not sure about the OP's real code
but at least his test case gets indented like this with Emacs's trunk:

vec = [...
one;...
two;...
three];

So it looks like the bug is already fixed.


Stefan

[Leo Liu]

On 2013-12-02 23:15 +0800, Stefan Monnier wrote:
> Looks like we've all been pretty dumb: not sure about the OP's real code
> but at least his test case gets indented like this with Emacs's trunk:
>
> vec = [...
> one;...
> two;...
> three];
>
> So it looks like the bug is already fixed.

I was able to reproduce the bug some time ago but indeed this seems
fixed in trunk. but

x = ...
12

doesn't indent the second line correctly.

Leo

[Stefan Monnier]

> x = ...
> 12

> doesn't indent the second line correctly.

That's simply for lack of a corresponding rule in octave-smie-rules.
Try M-x smie-edebug RET


Stefan

[Rüdiger Sonderfeld]

On Tuesday 03 December 2013 09:56:39 Tom Olin wrote:
> Just FWIW, I'm still seeing the problem. I get:

>
> vec = [...
> one;...
> two;...
> three];
>

> I'm using:
>
> GNU Emacs 24.3.1 (x86_64-apple-darwin12.2.0, X toolkit, Xaw scroll bars) of
> 2013-03-21
>
> from MacPorts. How far from HEAD is that?

Very far. Thanks to Leo Octave mode was improved quite significantly since
the release of 24.3. It should be backward compatible to 24.3. If you want
to try it you could copy octave.el from bzr and load it in your Emacs.

Regards,
Rüdiger

[Rüdiger Sonderfeld]