bug#14413: 24.2; message-mode-abbrev-table

[Glenn Morris]

Emanuel Berg wrote:

>> (add-hook 'message-mode-hook
>> (lambda ()
>> ;; dynamic abbreviations for org-mode
>> (setq local-abbrev-table message-mode-abbrev-table)))
>
> "This should not be needed. Please M-x report-emacs-bug RET" (Stefan
> Monnier @ gnu.emacs.help)

message-mode uses (has always used, AFAICS) the normal text-mode abbrev table:

(setq local-abbrev-table text-mode-abbrev-table)

What's the bug supposed to be?
That message-mode-abbrev-table exists at all, because message forgets to
pass an :abbrev argument to define-derived-mode?

[Stefan Monnier]

> message-mode uses (has always used, AFAICS) the normal text-mode
> abbrev table:

> (setq local-abbrev-table text-mode-abbrev-table)

> What's the bug supposed to be?
> That message-mode-abbrev-table exists at all, because message forgets to
> pass an :abbrev argument to define-derived-mode?

The right thing is for message-mode to use message-mode-abbrev-table and
for this abbrev-table to inherit from text-mode-abbrev-table.
In theory, it should happen automatically (assuming we remove the above
offending setq) thanks to define-derived-mode.


Stefan

[Glenn Morris]

Version: 24.4

Stefan Monnier wrote:

> The right thing is for message-mode to use message-mode-abbrev-table and
> for this abbrev-table to inherit from text-mode-abbrev-table.
> In theory, it should happen automatically (assuming we remove the above
> offending setq) thanks to define-derived-mode.

ok.