bug#1286: marked as done (comment-dwim on a comment line does not toggle comment)
Emacs bug Tracking System
Your message dated Fri, 31 Oct 2008 21:33:32 -0400
with message-id <jwvabcknsf4.fsf-mon...@gnu.org>
and subject line Re: bug#1286: comment-dwim on a comment line does not toggle comment
has caused the Emacs bug report #1286,
regarding comment-dwim on a comment line does not toggle comment
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact d...@donarmstrong.com
immediately.)
--
1286: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1286
Emacs Bug Tracking System
Contact d...@donarmstrong.com with problems
Xavier Maillard
this appears to be like a bug.
in emacs-lisp-mode, if you have a comment like this:
;; This is a comment
and your cursor is somewhere on that line. Now, do comment-dwim, it
doesn't uncomment the line. It just moves the cursor to the T
in This .
Same behavior in cperl mode and probably all others.
I think this might be by design, but it seems counter-intuitive.
I am sure you read it but just in case:
comment-dwim is an interactive autoloaded Lisp function in
`newcomment.el'.
It is bound to M-;.
(comment-dwim ARG)
Call the comment command you want (Do What I Mean).
If the region is active and `transient-mark-mode' is on, call
`comment-region' (unless it only consists of comments, in which
case it calls `uncomment-region').
Else, if the current line is empty, call `comment-insert-comment-function'
if it is defined, otherwise insert a comment and indent it.
Else if a prefix ARG is specified, call `comment-kill'.
Else, call `comment-indent'.
You can configure `comment-style' to change the way regions are commented.
For my point of view, this is well defined here and it behaves
just as described.
Xavier
--
http://www.gnu.org
http://www.april.org
http://www.lolica.org
Xavier Maillard
xah lee
«For my point of view, this is well defined here and it behaves just
as described.»
I agree it's well defined and documented. However, i think it is not
intuitive, even people who have used emacs for 3 or more years and
are familiar with its terminologies and behaviors.
when a cursor is on a comment line (whole line is comment) and
there's no active region, i don't see any reason it shouldn't just
uncomment the line when calling comment-dwim. I would say that, any
person, including those using emacs for 3 or more years, who are
using comment-dwim for the first time, would expect it to uncomment it.
is there a reason why it shouldn't uncomment other than “it's that
way for long”?
PS I only started to use comment-dwim in this or last year. In the
past, i've always used string-rectangle and kill-rectangle. I started
to use emacs daily in a day job since 1998, and for the first 7 years
i use it exclusively in terminals.
Xah
∑ http://xahlee.org/
☄
----------------------------------
;; This is a comment
(comment-dwim ARG)
-----------------------
xah lee
Stefan Monnier
> active region, i don't see any reason it shouldn't just uncomment the line
> when calling comment-dwim. I would say that, any person, including those
I, on the other hand, don't see why it should do that. What would be
the logic behind it? And according to that logic what should it do if
the line contains a comment as well as some code?
As explained, the M-; behavior you're seeing has been with us for many
many years, so there needs to be a good reason for the change (and the
previous behavior of inserting a comment marker and/or reindenting
a preexisting comment marker, should still be available somewhere).
Stefan
Stefan Monnier
Xavier Maillard
Xavier Maillard wrote:
«For my point of view, this is well defined here and it behaves just
as described.»
I agree it's well defined and documented. However, i think it is not
intuitive, even people who have used emacs for 3 or more years and
are familiar with its terminologies and behaviors.
when a cursor is on a comment line (whole line is comment) and
there's no active region, i don't see any reason it shouldn't just
uncomment the line when calling comment-dwim. I would say that, any
person, including those using emacs for 3 or more years, who are
using comment-dwim for the first time, would expect it to uncomment it.
Speaking for myself, as a more-than-3-years emacs user, I do not
see why it should uncomment anything here. I am used to activate
a commented region and then M-; to uncomment it. M-; has always
done the right thing: comment and indent.
Dunno what other people think about that though.