Add Swedish translation. - git-version-control

The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Message from discussion Add Swedish translation.
Received-SPF: pass (google.com: best guess record for domain of git-ow...@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=fx9yyjENbliJAgKBIyAJlYgIu7iXo14tbiXAEnRVHoBUALDcke93HlPH3Jxw4HIrFT
         EBSvq12HwkGlCyCed3ZHeHyH0uzPnKf1NcQcf7rt+SMO/XvgxE8Yhuth7B96yj/y3bug
         QVF4l3Z4wp5JmJ/ULZoUYFZSoI75w6I+EEyNo=
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.00.1009130810580.31...@ds9.cixit.se>
References: <20100912202111.B11522FC00@perkele>
	<AANLkTikg1vD33f6Rj4UEzsbrUemta6NbRWWH22h2Y...@mail.gmail.com>
	<alpine.DEB.2.00.1009130810580.31...@ds9.cixit.se>
Date: Mon, 13 Sep 2010 13:35:59 +0000
Message-ID: <AANLkTinhmBHQzkdEY88Oa-XsZQ4VAUz0Tci+gOt=f...@mail.gmail.com>
Subject: Re: [PATCH 2/2] Add Swedish translation.
From: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= <ava...@gmail.com>
To: Peter Krefting <pe...@softwolves.pp.se>
Cc: g...@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: git-ow...@vger.kernel.org
Precedence: bulk

On Mon, Sep 13, 2010 at 07:15, Peter Krefting <pe...@softwolves.pp.se> wrote:
> Ã†var ArnfjÃ¶rÃ° Bjarmason:
>
>> * Doesn't follow the "Initializing a .po file" docs in
>> Â t/README. Here's what you get after applying the little Perl
>> Â cleanup program there to it:
>
> Well, I just used the standard commands for creating it.

What commands did you use? I different things on GNU gettext 0.18.1
using the commands documented in po/README, e.g.:

    @@ -12,0 +13 @@ msgstr ""
    +"Language: sv\n"

    @@ -16 +17 @@ msgstr ""
    -"Plural-Forms: nplurals=2; plural=(n != 1);"
    +"Plural-Forms: nplurals=2; plural=(n != 1);\n"

And the line wrapping is different after a msgmerge:

    @@ -533 +532,3 @@ msgid "-a and -r options to 'git branch' do not
make sense with a branch name"
    -msgstr "flaggorna -a och -r pÃ¥ \"git branch\" kan inte anges
tillsammans med ett grennamn"
    +msgstr ""
    +"flaggorna -a och -r pÃ¥ \"git branch\" kan inte anges tillsammans med ett "
    +"grennamn"

Which is probably because you edited it with an unofficial PO editor
(i.e. not Emacs's po-mode.el) and didn't do msgmerge afterwards.

>> Â  Â  Â  @@ -1,54 +1,38 @@
>> Â  Â  Â  -# Swedish translation of git
>> Â  Â  Â  -# Copyright Â© 2010 Peter krefting <pe...@softwolves.pp.se>
>> Â  Â  Â  -# Peter Krefting <pe...@softwolves.pp.se>, 2010.
>> Â  Â  Â  -#
>
> That's a standard header, which is good to keep for clarity. If we want to
> go through Translation Project (which I still do recommend), it is required.

We could just autogenerate it from the git.git logs before uploading
to the Translation Project if it comes to that. Having comments before
the <msgstr ""> also means it can't be updated with the example
snippet in po/README.

>> Â  Â  Â  -"PO-Revision-Date: 2010-09-12 21:07+0100\n"
>
> That's a good reference header to see how out-of-date the translation is.

But redundant to `git log sv.po | grep ^Date | head -n1`. And since
it's autogenerated it'll cause merge conflicts across different git
branches eventually.

>> Â  Â  Â  -"Last-Translator: Peter Krefting <pe...@softwolves.pp.se>\n"
>> Â  Â  Â  -"Language-Team: Swedish <tp...@listor.tp-sv.se>\n"
>
> These are standard headers to make it easier to find out who to blame the
> translation on. I haven't actually submitted my translation for review on
> the Swedish list yet, but will do so soon enough.

Ditto redundant to `git log sv.po | grep ^Author`.  .

>> Â  Â  Â  -#: wt-status.c:56
>
> These context lines are invaluable when figuring out how to translate stuff,
> and to track back strings after the fact. I do not like the idea of removing
> them.

Yes they're useful while translating. But as documented in po/README's
"Updating a .po file" you can use them while doing that without
submitting them to git.git.

If they're included the majority of any po/*.po update will be updates
to auto-generated line number comments.

Anyway, I don't feel strongly about any of the above. Maybe we're
omitting some some PO header entries that we should use, and maybe we
should include PO commits (although that'd need a custom merge
driver).

But we should do that with a patch to po/README and implement it
consistently across all the po/*.po files, having something that
deviates from the norm is a pain to maintain.

>> * Commit message should be "po/sv.po: add Swedish translation". It
>> Â makes it much easier to `git log --grep=po/` or `git log
>> Â --grep=po/sv.po` in the future.
>
> Git has that information already, no need to put it in the commit message
> :-)

It's not using the "<subsystem>: <message> <no-full-stop>"
convention. All the existing commits in ab/i18n use that convention,
and I'd prefer to keep it that way.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
Account Options
