Google Groups Home
Help | Sign in
Log rendering
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
Jyrki J.  
View profile
 More options Mar 17, 3:29 pm
From: "Jyrki J." <jyrkij.li...@gmail.com>
Date: Mon, 17 Mar 2008 12:29:46 -0700 (PDT)
Local: Mon, Mar 17 2008 3:29 pm
Subject: Log rendering
Hello,
and thanks for the great plugin!

I've been using git-tmbundle (as well as git) for a while only and am
facing TextMate's rendering bug. When displaying logs the commits end
up displayed in the wrong order.

Why is the variable @script_at_top set to true everywhere? Wouldn't it
be easier to add a before_filter to application controller rather than
to every(?) controller? Anyhow, shouldn't @script_at_top be false
because it's "causing" the rendering bug?

Then there is this syntax error:
<code>
diff --git a/Support/app/views/log/layout.html.erb b/Support/app/views/
log/layout.html.erb
index 1ff6517..67a44b8 100644
--- a/Support/app/views/log/layout.html.erb
+++ b/Support/app/views/log/layout.html.erb
@@ -15,5 +15,5 @@
 </body>
 <% unless @script_at_top %>
   <%= javascript_include_tag "prototype", "rb_gateway",
"log_collapse" %>
-<%= end %>
+<% end %>
 </html>
\ No newline at end of file
</code>

-jyrkij


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
timcharper  
View profile
 More options Mar 24, 3:07 am
From: timcharper <timchar...@gmail.com>
Date: Mon, 24 Mar 2008 00:07:57 -0700 (PDT)
Local: Mon, Mar 24 2008 3:07 am
Subject: Re: Log rendering
Hi Jyrki,

script_at_top was indeed causing the error in the log files.

As for including this the "Application controller" - this is
undesired.  The desired default is for the script to be loaded at the
bottom.

I thought the log output was going to be ok (and was in some tests),
because I was explicitly calling "flush" after closing off a block of
HTML.  Apparently, I was wrong :)

script_at_top=true is desired and works well for commands like push/
pull.  It would've been nice for log file outputting to allow
expansion of log commits before all logs finish rendering.

This issue has been fixed.  Update to the latest.

Thanks!

Tim

On Mar 17, 1:29 pm, "Jyrki J." <jyrkij.li...@gmail.com> wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2008 Google