Google Groups Home
Help | Sign in
"Commit..." fails to commit files when not in a project.
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
Martin Kühl  
View profile
 More options Mar 18, 11:14 am
From: Martin Kühl <martin.ku...@gmail.com>
Date: Tue, 18 Mar 2008 08:14:32 -0700 (PDT)
Local: Tues, Mar 18 2008 11:14 am
Subject: "Commit..." fails to commit files when not in a project.
CommitController uses `@base` to shorten the list of files to commit
to relative names, but that variable is never set (except in
SCM::Git.SubmoduleBase, but that isn't relevant here).
The `shorten` method continues to work when inside a project as is
tries to use `$TM_PROJECT_DIRECTORY` anyway, but otherwise, git add
and git commit are called with the absolute paths to the changed files
and throw errors.

To fix this, we can call shorten with `git.git_base`.

A patch for this can be found at: <http://pastie.caboo.se/167301>

Cheers and thanks for the awesome bundle,
Martin


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
timcharper  
View profile
 More options Mar 24, 3:09 am
From: timcharper <timchar...@gmail.com>
Date: Mon, 24 Mar 2008 00:09:06 -0700 (PDT)
Local: Mon, Mar 24 2008 3:09 am
Subject: Re: "Commit..." fails to commit files when not in a project.
Thanks for the fix!  Applied.  I fixed this on my own and then noticed
your patch.  I'll get you duly credited for the fix for the next
release.

Tim

On Mar 18, 9:14 am, Martin Kühl <martin.ku...@gmail.com> wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2008 Google