Feature request: Autoremove Deleted Repositories

[Jacob Winski]

Hi,

The "Select Repository..." window should *not* show repositories that no longer exist.

Currently, it shows everything and even allows one to select a repo that no longer exists, which just closes and reopens the "Select Repository" window.

On every start of "Select Repository.." window, an autoremove function should go through every item to make sure it still exists, and remove it from the list if it does not.

I suggest checking <dir path>/.git because it's possible to still have <dir path> but without any git information, so os.path.isdir(repo_dir_path + "/.git") should do the trick.

[David Aguilar]

Thanks for the suggestion, Jacob.
This would indeed be quite helpful.

I have one tiny note about performance --
we should only do this check when the "Select Repository" window
is being shown, and ideally in a background thread.

Launching git-cola from the command line when you are already
inside a repo does not show this dialog so it can avoid needing
to do these checks; they can be expensive when you have lots
of repos, especially so when they are on slow network disks.

I'll open a github issue so that I don't forget ;-)

I'm currently trying to tackle the KDE autocomplete issue[1]
before tagging the next release. Has anyone else run into it?

[1] https://github.com/git-cola/git-cola/issues/144
--
David

[David Aguilar]

On Wed, Jan 9, 2013 at 12:36 AM, <vgolo...@gmail.com> wrote:
> Such functionality really will be very useful in git-cola.

https://github.com/git-cola/git-cola/commit/ddfc2051d28829821fde7f6b52bcfc612f304692

https://github.com/git-cola/git-cola/commit/0399e3af734ba67fd1bd1791695c93c0f0bbdcb8

enjoy,
--
David

[vgolo...@gmail.com]

Much appreciated.