Fedora 10/inotify exception

25 views
Skip to first unread message

manithree

unread,
Jan 15, 2009, 7:19:35 PM1/15/09
to git-cola
I new there was a reason I was getting tired of Ctrl+R in cola. I
think I had a problem early on and did a 'yum remove python-inotify'
I just re-installed python-inotify in Fedora 10, and now when I try to
run git-cola I get:


Traceback (most recent call last):
File "/home/blr/bin/git-cola", line 56, in <module>
main()
File "home/blr/lib/python2.5/site-packages/cola/main.py", line 128,
in main
File "home/blr/lib/python2.5/site-packages/cola/qobserver.py", line
56, in __init__
File "/usr/lib64/python2.5/site-packages/PIL/__init__.py", line 207,
in init

File "/usr/lib64/python2.5/site-packages/PIL/__init__.py", line
1111, in start_inotify_thread

File "home/blr/lib/python2.5/site-packages/cola/inotify.py", line
50, in __init__
AttributeError: type object 'EventsCodes' has no attribute 'IN_CREATE'

I haven't had a chance to look at this yet, so I'm hoping it's just
stupidity on my part and somebody else already has a solution ;-)

yum remove python-inotify and cola works again, but with lots of Ctrl-
Rs

Barry

David Aguilar

unread,
Jan 15, 2009, 11:45:57 PM1/15/09
to git-...@googlegroups.com
On Thu, Jan 15, 2009 at 4:19 PM, manithree <mani...@gmail.com> wrote:
>
> I new there was a reason I was getting tired of Ctrl+R in cola. I
> think I had a problem early on and did a 'yum remove python-inotify'
> I just re-installed python-inotify in Fedora 10, and now when I try to
> run git-cola I get:
>
>
> Traceback (most recent call last):
> File "home/blr/lib/python2.5/site-packages/cola/inotify.py", line
> 50, in __init__
> AttributeError: type object 'EventsCodes' has no attribute 'IN_CREATE'
>
> I haven't had a chance to look at this yet, so I'm hoping it's just
> stupidity on my part and somebody else already has a solution ;-)
>
> yum remove python-inotify and cola works again, but with lots of Ctrl-
> Rs
>
> Barry
>

This sounds like the pyinotify API has changed at some point.
What version of pyinotify are you using?

$ dpkg-query -s python-pyinotify
Version: 0.7.1-1

If you send me the output of the following python code it should help
in getting a patch together:

import pprint
import pyinotify
pprint.pprint(dir(pyinotify.EventsCodes))

BTW git-difftool is broken on windows with the latest master (I
followed the suggestions from:
http://n2.nabble.com/git-difftool-td1814817.html
and along the way I lost windows support).

I have a patch that fixes it and will be committing that tonight.

I'm almost just about done with a windows installer, too. The last
thing holding me up was the difftool issue.


--
David

Barry Roberts

unread,
Jan 16, 2009, 12:19:17 AM1/16/09
to git-...@googlegroups.com
David Aguilar wrote:
> On Thu, Jan 15, 2009 at 4:19 PM, manithree <mani...@gmail.com> wrote:
>> I new there was a reason I was getting tired of Ctrl+R in cola. I
>> think I had a problem early on and did a 'yum remove python-inotify'
>> I just re-installed python-inotify in Fedora 10, and now when I try to
>> run git-cola I get:
>>
>>
>> Traceback (most recent call last):
>> File "home/blr/lib/python2.5/site-packages/cola/inotify.py", line
>> 50, in __init__
>> AttributeError: type object 'EventsCodes' has no attribute 'IN_CREATE'
>>
>> I haven't had a chance to look at this yet, so I'm hoping it's just
>> stupidity on my part and somebody else already has a solution ;-)
>>
>> yum remove python-inotify and cola works again, but with lots of Ctrl-
>> Rs
>>
>> Barry
>>
>
> This sounds like the pyinotify API has changed at some point.
> What version of pyinotify are you using?
>
> $ dpkg-query -s python-pyinotify
> Version: 0.7.1-1

$ rpm -qa | grep python-inotify
python-inotify-0.8.0-3.r.fc10.noarch
h


> If you send me the output of the following python code it should help
> in getting a patch together:
>
> import pprint
> import pyinotify
> pprint.pprint(dir(pyinotify.EventsCodes))
>

>>> import pprint
>>> import pyinotify
INFO: Maybe it could speed-up a little bit if you had psyco installed
(not required).
>>> pprint.pprint(dir(pyinotify.EventsCodes))
['ALL_FLAGS',
'ALL_VALUES',
'EVENT_FLAGS',
'FLAG_COLLECTIONS',
'OP_FLAGS',
'SPECIAL_FLAGS',
'__class__',
'__delattr__',
'__dict__',
'__doc__',
'__getattribute__',
'__hash__',
'__init__',
'__module__',
'__new__',
'__reduce__',
'__reduce_ex__',
'__repr__',
'__setattr__',
'__str__',
'__weakref__',
'maskname']
>>>


> BTW git-difftool is broken on windows with the latest master (I
> followed the suggestions from:
> http://n2.nabble.com/git-difftool-td1814817.html
> and along the way I lost windows support).
>
> I have a patch that fixes it and will be committing that tonight.
>

I would tell my Window users to upgrade, but ...

> I'm almost just about done with a windows installer, too. The last
> thing holding me up was the difftool issue.
>

W00t! I've been reading up on InnoSetup, but I just couldn't get myself
to work on it. But I bet I'll get you some testers for it soon.

Thanks,
Barry

David Aguilar

unread,
Jan 16, 2009, 12:57:30 AM1/16/09
to git-...@googlegroups.com
On Thu, Jan 15, 2009 at 9:19 PM, Barry Roberts <b...@robertsr.us> wrote:
>
>>> pprint.pprint(dir(pyinotify.EventsCodes))
> ['ALL_FLAGS',
> 'ALL_VALUES',
> 'EVENT_FLAGS',
> 'FLAG_COLLECTIONS',
> 'OP_FLAGS',
> 'SPECIAL_FLAGS',
> '__class__',
> ...
> 'maskname']
> >>>
>

Yup, the API changed.
I just pushed out a fix that makes cola compatible with both versions
of the API. Thanks for catching that.


>> BTW git-difftool is broken on windows with the latest master (I
>> followed the suggestions from:
>> http://n2.nabble.com/git-difftool-td1814817.html
>> and along the way I lost windows support).
>>
>> I have a patch that fixes it and will be committing that tonight.
>>

This is fixed now too.

git-difftool is better now since users don't have to learn anything new.

All of your 'git diff' knowledge transfers right over to git-difftool.
It now accepts the same exact flags as git diff
(except, of course, for --tool/-t, --help,-h and --no-prompt, which
are difftool-specific).

>
> I would tell my Window users to upgrade, but ...
>
>> I'm almost just about done with a windows installer, too. The last
>> thing holding me up was the difftool issue.
>>
>
> W00t! I've been reading up on InnoSetup, but I just couldn't get myself
> to work on it. But I bet I'll get you some testers for it soon.
>
> Thanks,
> Barry
>

Good stuff. The msysgit guys really did a great job so I've just been
learning by reading through their installer source.


--
David

Reply all
Reply to author
Forward
0 new messages