subprocess patch

[CMGS]

I write a subprcess patch for gevent, see https://gist.github.com/2785610.

the test passed in gevent 1.0b1, however, failed in gevent 1.0b2.

then I review the code I found that in gevent 1.0b1, after children process dead, it will return 0, but return None in gevent 1.0b2.

so...what's different between 1.0b1 and 1.0b2?

--

-CMGS

A simple coder.

Love travel, sports especially outdoor sports and computer technology.

Have a dream that one day can tour around.

[Damien Churchill]

On 25 May 2012 04:58, CMGS <ils...@gmail.com> wrote:
>
> so...what's different between 1.0b1 and 1.0b2?
>

There's a subprocess[0] module in gevent now.

https://bitbucket.org/denis/gevent/src/5dca6e927bc4/gevent/subprocess.py

[Executier Godlike]

Thank you for the subprocess.
While it is already shipped with gevent there is no proper version for
gevent-py3k. Until gevent doesn't support py3k it is very useful.

It contains some typos like "from sp import ...".
And does "patch_subprocess()" really needed?

> I write a subprcess patch for gevent, see
> https://gist.github.com/2785610. the test passed in gevent 1.0b1,
> however, failed in gevent 1.0b2.
>
> then I review the code I found that in gevent 1.0b1, after children
> process dead, it will return 0, but return None in gevent 1.0b2.
>
> so...what's different between 1.0b1 and 1.0b2?
>

--

Alexandre Kandalintsev

[CMGS]

well..yes..'from sp import..' is a typo..sorry

in your code patch_subprocess() is necessary.

在 2012年5月29日星期二UTC+8上午4时23分32秒，exe写道：