Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Issue 1100 in gerrit: All draft comments should be sent out with the review.
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  5 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
ger...@googlecode.com  
View profile  
 More options Aug 18 2011, 12:54 pm
From: ger...@googlecode.com
Date: Thu, 18 Aug 2011 16:54:08 +0000
Local: Thurs, Aug 18 2011 12:54 pm
Subject: Issue 1100 in gerrit: All draft comments should be sent out with the review.
Status: New
Owner: ----
Labels: Type-Feature Priority-Minor

New issue 1100 by vben...@chromium.org: All draft comments should be sent  
out with the review.
http://code.google.com/p/gerrit/issues/detail?id=1100

A very common situation: there is change in flight, with several versions  
in the works. Different comment threads are associated with code in  
different patchsets. When the reviewer/submitter presses the "publish  
comments" button, only the draft of the current patchset is published. This  
often causes unpublished drafts.

It would be more robust if all existing draft comments (on all patchsts)  
were included in the email.

Ideally, all comment threads should be promoted to the latest patchset  
(which of course is not always possible) - this would make the review  
easier with all comment threads visible on the latest patchset.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options May 17 2012, 1:59 pm
From: ger...@googlecode.com
Date: Thu, 17 May 2012 17:59:14 +0000
Local: Thurs, May 17 2012 1:59 pm
Subject: Re: Issue 1100 in gerrit: All draft comments should be sent out with the review.

Comment #1 on issue 1100 by sarmstr...@litl.com: All draft comments should  
be sent out with the review.
http://code.google.com/p/gerrit/issues/detail?id=1100

This is an extremely annoying issue.  I am not aware of any way to publish  
my extensive draft comments without recreating all of them in the latest  
patch set.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options May 17 2012, 2:00 pm
From: ger...@googlecode.com
Date: Thu, 17 May 2012 18:00:55 +0000
Local: Thurs, May 17 2012 2:00 pm
Subject: Re: Issue 1100 in gerrit: All draft comments should be sent out with the review.

Comment #2 on issue 1100 by sarmstr...@litl.com: All draft comments should  
be sent out with the review.
http://code.google.com/p/gerrit/issues/detail?id=1100

This issue is extremely annoying.  It is not at all obvious how to publish  
draft comments on earlier patch set (you have to select a file from that  
patch and then hit 'r' from there to publish your review for that patch  
set).


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options Oct 1 2012, 4:56 pm
From: ger...@googlecode.com
Date: Mon, 01 Oct 2012 20:56:44 +0000
Local: Mon, Oct 1 2012 4:56 pm
Subject: Re: Issue 1100 in gerrit: All draft comments should be sent out with the review.

Comment #3 on issue 1100 by dgarr...@chromium.org: All draft comments  
should be sent out with the review.
http://code.google.com/p/gerrit/issues/detail?id=1100

This happens to me all the time, and sometimes upsets reviewers because I  
didn't reply to them.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options Oct 25 2012, 5:55 pm
From: ger...@googlecode.com
Date: Thu, 25 Oct 2012 21:54:59 +0000
Local: Thurs, Oct 25 2012 5:54 pm
Subject: Re: Issue 1100 in gerrit: All draft comments should be sent out with the review.

Comment #4 on issue 1100 by skaaaa...@gmail.com: All draft comments should  
be sent out with the review.
http://code.google.com/p/gerrit/issues/detail?id=1100

this issue is so disruptive... Especially when people are reviewing the  
same patch from different time zones.
please please, fix!


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »