Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Issue 1312 in gerrit: Can't get relative submodule subscriptions to work
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  5 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
ger...@googlecode.com  
View profile  
 More options Mar 29 2012, 10:57 am
From: ger...@googlecode.com
Date: Thu, 29 Mar 2012 14:57:01 +0000
Local: Thurs, Mar 29 2012 10:57 am
Subject: Issue 1312 in gerrit: Can't get relative submodule subscriptions to work
Status: New
Owner: ----
Labels: Type-Bug Priority-Minor

New issue 1312 by la...@lancehudson.com: Can't get relative submodule  
subscriptions to work
http://code.google.com/p/gerrit/issues/detail?id=1312

Affected Version: 2.3-RC0

What steps will reproduce the problem?
1. Create two projects (A and B)
2. Clone project A locally
3. Create a .gitmodules file in project A
[submodule "B"]
        path = B
        url = ../B.git
        branch = refs/heads/master
4. git submodule init (to check .gitmodules created correctly)
5. git submodule update (to create gitlink)
6. Commit and push the git link and .gitmodule
7. Clone project B locally
8. make changes in project B
9. Commit changes in project B
10. pull project A
11. git submodule update
12. change is not downloaded in submodule (gitlink was not updated)

What is the expected output? What do you see instead?
The gitlink would have been updated and the changes would have shown up in  
the submodule dir.

Please provide any additional information below.

I also have connected to the mysql database running this and do not see a  
subscription in the reviewdb.submodule_subscriptions table.

Looking at the code  
/gerrit/gerrit-server/src/main/java/com/google/gerrit/server/util/Submodule SectionParser.java  
L84

boolean urlIsRelative = url.startsWith("/");

It looks like gerrit requires relative submodules to begin with a '/'. I  
have been unable to get git (msysgit 1.7.9-preview20120201) to work  
properly with a submodule url starting with '/' or './', only '../' works.

Before going about the patching process I want to make sure I am attempting  
this correctly and haven't missing anything.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options Oct 25 2012, 3:45 pm
From: ger...@googlecode.com
Date: Thu, 25 Oct 2012 19:45:25 +0000
Local: Thurs, Oct 25 2012 3:45 pm
Subject: Re: Issue 1312 in gerrit: Can't get relative submodule subscriptions to work

Comment #1 on issue 1312 by phil.h...@gmail.com: Can't get relative  
submodule subscriptions to work
http://code.google.com/p/gerrit/issues/detail?id=1312

I had the same problem, but I didn't look in the code to see if relative  
URLs were already considered.  I think the "/" is definitely an error  
as "../" is also needed here in Linux-land.  Have you tried your patch?

In the meantime, I have this workaround which navigates through all my  
submodules and generates SQL statements to insert subscriptions.  I need  
this anyway for all my existing submodules as they are not being added as  
new in any case.

Here's what I used:
INSERT INTO submodule_subscriptions VALUES  
( '${SUBMODULE}' , '${BRANCH}', '${SUPERPROJECT}', '${BRANCH}', '${SUBMODULE_PATH}'  
);

For example,
INSERT INTO submodule_subscriptions VALUES  
( 'my/submodule' , 'refs/heads/master', 'my/superproject', 'refs/heads/master', 'submodule'  
);"


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options Oct 25 2012, 4:00 pm
From: ger...@googlecode.com
Date: Thu, 25 Oct 2012 20:00:00 +0000
Subject: Re: Issue 1312 in gerrit: Can't get relative submodule subscriptions to work

Comment #2 on issue 1312 by la...@lancehudson.com: Can't get relative  
submodule subscriptions to work
http://code.google.com/p/gerrit/issues/detail?id=1312

I did try my patch at the time. Currently I do not have a running gerrit  
instance.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options Nov 13 2012, 7:39 pm
From: ger...@googlecode.com
Date: Wed, 14 Nov 2012 00:39:57 +0000
Local: Tues, Nov 13 2012 7:39 pm
Subject: Re: Issue 1312 in gerrit: Can't get relative submodule subscriptions to work

Comment #3 on issue 1312 by phil.h...@gmail.com: Can't get relative  
submodule subscriptions to work
http://code.google.com/p/gerrit/issues/detail?id=1312

https://gerrit-review.googlesource.com/39372


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options Nov 30 2012, 5:26 am
From: ger...@googlecode.com
Date: Fri, 30 Nov 2012 10:26:12 +0000
Local: Fri, Nov 30 2012 5:26 am
Subject: Re: Issue 1312 in gerrit: Can't get relative submodule subscriptions to work
Updates:
        Status: Submitted
        Labels: FixedIn-2.6

Comment #4 on issue 1312 by david.pu...@sonymobile.com: Can't get relative  
submodule subscriptions to work
http://code.google.com/p/gerrit/issues/detail?id=1312

(No comment was entered for this change.)


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »