Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
The group you are posting to is a
Usenet group . Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
From:
ger... @googlecode.com
Date: Mon, 14 Mar 2011 20:10:35 +0000
Local: Mon, Mar 14 2011 4:10 pm
Subject: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
Status: New Owner: ---- Labels: Type-Bug Priority-Minor New issue 878 by pchida... @gmail.com: Unable to open side-by-side review in Opera 11.01+ http://code.google.com/p/gerrit/issues/detail?id=878
Affected Version:
What steps will reproduce the problem? 1. Open any C gerrit review and try to open the side by side review for a C file in Opera 11.01+ 2. Enable Java script console 3.
What is the expected output? What do you see instead? Instead of opening the review, there is an error on console
Please provide any additional information below.
JavaScript - https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2... Unknown thread Uncaught exception: TypeError: 'a.prettyPrintOne' is not a function Error thrown at line 362, column 39 in XLb(a, b, c, d) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2... return a.prettyPrintOne(b,c) called from line 316, column 20 in VLb(a, b, c) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2... return XLb($wnd[SLb.c],b,c,a.f.m) called from line 540, column 139 in HLb(a, b) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2... c=VLb(a,c,ILb(a)) called from line 431, column 103 in IGb(a) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2... HLb(c,a.c); called from line 548, column 48 in Vkb(a) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2... b=IGb(a); called from line 295, column 42 in $cb(a, b, c, d, e) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2... a.vc(e) called from line 541, column 533 in eib(a, b, c) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2... $cb(a.f,a.q,a.j,a.k,b); called from line 350, column 16 in fjb(a) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2... this.c.u==this.e&&eib(this.c,a,this.d) called from line 89, column 30 in eG(a) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2... this.Qb(a); called from line 116, column 130 in wdd(b, c, d) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2... c.xb(g)
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Fri, 18 Mar 2011 14:58:47 +0000
Local: Fri, Mar 18 2011 10:58 am
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
Comment #1 on issue 878 by pchida... @gmail.com: Unable to open side-by-side review in Opera 11.01+ http://code.google.com/p/gerrit/issues/detail?id=878
JavaScript - https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943... Unknown thread Uncaught exception: TypeError: 'a.prettyPrintOne' is not a function Error thrown at line 378, column 39 in nMb(a, b, c, d) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943... return a.prettyPrintOne(b,c) called from line 321, column 20 in lMb(a, b, c) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943... return nMb($wnd[iMb.c],b,c,a.f.m) called from line 543, column 139 in ZLb(a, b) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943... c=lMb(a,c,$Lb(a)) called from line 430, column 103 in $Gb(a) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943... ZLb(c,a.c); called from line 551, column 48 in llb(a) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943... b=$Gb(a); called from line 297, column 42 in qdb(a, b, c, d, e) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943... a.wc(e) called from line 544, column 533 in wib(a, b, c) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943... qdb(a.f,a.q,a.j,a.k,b); called from line 341, column 16 in xjb(a) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943... this.c.u==this.e&&wib(this.c,a,this.d) called from line 123, column 30 in wG(a) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943... this.Rb(a); called from line 167, column 130 in ofd(b, c, d) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943... c.yb(g)
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Wed, 23 Mar 2011 17:06:51 +0000
Local: Wed, Mar 23 2011 1:06 pm
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Tue, 12 Apr 2011 17:27:16 +0000
Local: Tues, Apr 12 2011 1:27 pm
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Mon, 25 Apr 2011 17:16:43 +0000
Local: Mon, Apr 25 2011 1:16 pm
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
Comment #4 on issue 878 by adea... @gmail.com: Unable to open side-by-side review in Opera 11.01+ http://code.google.com/p/gerrit/issues/detail?id=878
This is also very irritating for me (with the OpenAFS code review system). It looks like it may be a bug in GWT, but I wouldn't really know. If someone can provide some details that I could use to file a bug with them, I certainly wouldn't mind pursuing it.
Some kind of option to turn off the code highlighting would also be appreciated, to work around this, which seems like it would be much easier. I assume this issue would go away if we don't try syntax-highlighting on the code. Were it not for email notifications, right now I wouldn't be able to read inline comments at all without using a different browser.
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Fri, 20 May 2011 20:29:01 +0000
Local: Fri, May 20 2011 4:29 pm
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Wed, 22 Jun 2011 09:25:24 +0000
Local: Wed, Jun 22 2011 5:25 am
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
Comment #6 on issue 878 by auke.sch... @gmail.com: Unable to open side-by-side review in Opera 11.01+ http://code.google.com/p/gerrit/issues/detail?id=878
It looks like this isn't fixed in GWT 2.3 / Gerrit 2.2.1. Andriod uses Gerrit 2.2.1-57-g4efeb4f and egit uses 2.2.1-67-g17ca55f and both sites throw the TypeError ('b.prettyPrintOne' is not a function) in Opera 11.11 (OS X).
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Sun, 26 Jun 2011 15:07:43 +0000
Local: Sun, Jun 26 2011 11:07 am
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
Comment #8 on issue 878 by pchida... @gmail.com: Unable to open side-by-side review in Opera 11.01+ http://code.google.com/p/gerrit/issues/detail?id=878
I concur Android Gerrit 2.2.1 doesnt seem to fix this issue. I recollect that this used to work on Opera 10 even when Opera 11 did not work. I have tried pursuing this with opera devs. They dont seem to pay much heed. I am looking to see if anybody can provide a work around. I think in Opera this can be done with a local javascript that will provide the prettyPrintOne function override, but I dont have the know hows of how to get it in there.
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Sun, 26 Jun 2011 15:11:45 +0000
Local: Sun, Jun 26 2011 11:11 am
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
Comment #7 on issue 878 by pchida... @gmail.com: Unable to open side-by-side review in Opera 11.01+ http://code.google.com/p/gerrit/issues/detail?id=878
I concur Android Gerrit 2.2.1 doesnt seem to fix this issue. I recollect that this used to work on Opera 10 even when Opera 11 did not work. I have tried pursuing this with opera devs. They dont seem to pay much heed. I am looking to see if anybody can provide a work around. I think in Opera this can be done with a local javascript that will provide the prettyPrintOne function override, but I dont have the know hows of how to get it in there.
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Mon, 25 Jul 2011 16:05:10 +0000
Local: Mon, Jul 25 2011 12:05 pm
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Wed, 27 Jul 2011 15:56:50 +0000
Local: Wed, Jul 27 2011 11:56 am
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Thu, 28 Jul 2011 02:25:56 +0000
Local: Wed, Jul 27 2011 10:25 pm
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Wed, 18 Apr 2012 21:33:21 +0000
Local: Wed, Apr 18 2012 5:33 pm
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Thu, 19 Apr 2012 08:56:56 +0000
Local: Thurs, Apr 19 2012 4:56 am
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
Comment #13 on issue 878 by auke.sch... @gmail.com: Unable to open side-by-side review in Opera 11.01+ http://code.google.com/p/gerrit/issues/detail?id=878
I think it's a bug in Opera because Opera 11.00 works fine and the error occurs first in Opera 11.01 and is still there in Opera 11.62 and Opera Next (12.00).
I reported it to Opera again (DSK-358177, 2012/02/24) but unfortunately there is no response on the bug report.
Does somebody have a clear picture of what is causing the missing function? Has anyone tried a workaround with Opera user javascript?
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Fri, 20 Apr 2012 14:26:41 +0000
Local: Fri, Apr 20 2012 10:26 am
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Fri, 04 May 2012 00:20:46 +0000
Local: Thurs, May 3 2012 8:20 pm
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
Comment #15 on issue 878 by adea... @gmail.com: Unable to open side-by-side
review in Opera 11.01+
http://code.google.com/p/gerrit/issues/detail?id=878
> Has anyone tried a workaround with Opera user javascript?
This can be worked around if syntax highlighting is disabled. Before, I
wasn't aware that this was even possible, but it is possible to disable in
the side-by-side or unified review interface. Since that interface doesn't
load due to this bug in the first place, I've found two ways to disable it:
1. Open the commit message in side-by-side or unified view. This requires
some version of gerrit or something, I'm sure. Viewing the commit message
in these views doesn't fail for me.
2. Open a source file in side-by-side or unified view in Firefox, or
another browser that doesn't encounter this problem.
From there, you can deselect the "Syntax Coloring" checkbox near the top,
and then click the "Update" button. After that is done, viewing any file in
the side-by-side or unified view works for me.
I'm sure that setting won't be retained if you're not logged in and move
between machines, etc. It's also possible to force this off with user
javascript, but by the time I figured that out I realized it wasn't
necessary :)
I'm still trying to look into the real problem when I can, but this appears
to be a usable workaround for me in the meantime.
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Wed, 16 May 2012 06:36:47 +0000
Local: Wed, May 16 2012 2:36 am
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
Comment #16 on issue 878 by nitzan... @gmail.com: Unable to open
side-by-side review in Opera 11.01+
http://code.google.com/p/gerrit/issues/detail?id=878
the workaround above does work. what does the Opera team need to know? we
should all report it. maybe it'll get the dev team's attention then.
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Sat, 16 Jun 2012 12:31:18 +0000
Local: Sat, Jun 16 2012 8:31 am
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
Comment #17 on issue 878 by jocula... @gmail.com: Unable to open
side-by-side review in Opera 11.01+
http://code.google.com/p/gerrit/issues/detail?id=878
Disabling the syntax highlighting works for me
Opera 12.0 AM64 on xUbuntu 12.04
Anyone tried to define user.js with prettyPrintOne()? Why it fails?
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Wed, 25 Jul 2012 20:18:35 +0000
Local: Wed, Jul 25 2012 4:18 pm
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Thu, 18 Oct 2012 19:35:11 +0000
Local: Thurs, Oct 18 2012 3:35 pm
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Thu, 18 Oct 2012 19:50:17 +0000
Local: Thurs, Oct 18 2012 3:50 pm
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
Comment #20 on issue 878 by daniel.w... @wikimedia.de: Unable to open
side-by-side review in Opera 11.01+
http://code.google.com/p/gerrit/issues/detail?id=878
A simple fix for this would be great. Why not simply check for the Opera
version and disable the Syntax highlighting?
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Sun, 21 Oct 2012 17:30:45 +0000
Local: Sun, Oct 21 2012 1:30 pm
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
ger... @googlecode.com
Date: Tue, 19 Feb 2013 17:41:40 +0000
Local: Tues, Feb 19 2013 12:41 pm
Subject: Re: Issue 878 in gerrit: Unable to open side-by-side review in Opera 11.01+
You must
Sign in before you can post messages.
You do not have the permission required to post.