Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Issue 1374 in gerrit: Push Merge leads to files to be regarded as new
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  8 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
ger...@googlecode.com  
View profile  
 More options May 7 2012, 4:49 am
From: ger...@googlecode.com
Date: Mon, 07 May 2012 08:49:25 +0000
Local: Mon, May 7 2012 4:49 am
Subject: Issue 1374 in gerrit: Push Merge leads to files to be regarded as new
Status: New
Owner: ----
Labels: Type-Bug Priority-Minor

New issue 1374 by j...@rbcon.com: Push Merge leads to files to be regarded  
as new
http://code.google.com/p/gerrit/issues/detail?id=1374

************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.2.2.1, 2.3, 2.4

What steps will reproduce the problem?
1.Create a repo
2.Create a branch named r10 of master
3.Push different changes to master and the branch for some days
4.Merge r10 to master
5.Push Merge to gerrit for review

What is the expected output? What do you see instead?
Expect output: Only the different files listed for review
Instead: All the files are listed with marked New File

Please provide any additional information below.
Take http://reviews.cloudfoundry.org/#/c/5120/ for the bug reference


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options May 7 2012, 4:53 am
From: ger...@googlecode.com
Date: Mon, 07 May 2012 08:53:46 +0000
Local: Mon, May 7 2012 4:53 am
Subject: Re: Issue 1374 in gerrit: Push Merge leads to files to be regarded as new

Comment #1 on issue 1374 by j...@rbcon.com: Push Merge leads to files to be  
regarded as new
http://code.google.com/p/gerrit/issues/detail?id=1374

I also tested it on 2.1.7, the issue is different with above, the commit  
will not display any changes there when review.

So I guess higher version Gerrit(>=2.2) is try to fix the legacy problem in  
2.1.7 but not good enough.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options May 7 2012, 3:07 pm
From: ger...@googlecode.com
Date: Mon, 07 May 2012 19:07:11 +0000
Local: Mon, May 7 2012 3:07 pm
Subject: Re: Issue 1374 in gerrit: Push Merge leads to files to be regarded as new

Comment #2 on issue 1374 by bklar...@gmail.com: Push Merge leads to files  
to be regarded as new
http://code.google.com/p/gerrit/issues/detail?id=1374

Not quite - Gerrit didn't show any diffs for merge commits before 2.2ish.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options May 9 2012, 1:48 pm
From: ger...@googlecode.com
Date: Wed, 09 May 2012 17:48:03 +0000
Local: Wed, May 9 2012 1:48 pm
Subject: Re: Issue 1374 in gerrit: Push Merge leads to files to be regarded as new

Comment #3 on issue 1374 by j...@rbcon.com: Push Merge leads to files to be  
regarded as new
http://code.google.com/p/gerrit/issues/detail?id=1374

Current Gerrit (>=2.2) will show NEW files for merge commits some time,  
base on our investigation it more likes a UI problem because it's no  
problem with actual git data after submit.

But we still wonder when this UI bug can be fixed well.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options May 9 2012, 3:25 pm
From: ger...@googlecode.com
Date: Wed, 09 May 2012 19:25:07 +0000
Local: Wed, May 9 2012 3:25 pm
Subject: Re: Issue 1374 in gerrit: Push Merge leads to files to be regarded as new

Comment #4 on issue 1374 by bklar...@gmail.com: Push Merge leads to files  
to be regarded as new
http://code.google.com/p/gerrit/issues/detail?id=1374

This happens when there are multiple merge bases.  jgit doesn't know how to  
create a merge in this case and punts.  I'm not sure how we should best  
handle this situation - the ideal fix is to teach jgit to handle multiple  
merge bases.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options Jun 21 2012, 2:19 pm
From: ger...@googlecode.com
Date: Thu, 21 Jun 2012 18:19:27 +0000
Local: Thurs, Jun 21 2012 2:19 pm
Subject: Re: Issue 1374 in gerrit: Push Merge leads to files to be regarded as new

Comment #5 on issue 1374 by jhans...@myyearbook.com: Push Merge leads to  
files to be regarded as new
http://code.google.com/p/gerrit/issues/detail?id=1374

This still occurs on 2.4.1.

@bklarson: Aren't all merges with multiple bases (isn't that what Merge  
means)?  Do you mean there are more than 2 bases?  In our case, the merge  
commit has only 2 parents, and the two do have a common ancestor.  I may be  
misunderstanding your terminology -- do you have an example that might  
cause something like this?  And possibly a workaround that we can be aware  
of so that we can avoid this situation in the future?


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options Jun 21 2012, 2:50 pm
From: ger...@googlecode.com
Date: Thu, 21 Jun 2012 18:50:13 +0000
Local: Thurs, Jun 21 2012 2:50 pm
Subject: Re: Issue 1374 in gerrit: Push Merge leads to files to be regarded as new

Comment #6 on issue 1374 by bklar...@gmail.com: Push Merge leads to files  
to be regarded as new
http://code.google.com/p/gerrit/issues/detail?id=1374

@jhansche - this is the best example I could find:  
http://codicesoftware.blogspot.com/2011/09/merge-recursive-strategy.html.  
Unfortunately I'm not enough of a git expert to give a better answer or  
implement recursive merging in jgit.

See also https://bugs.eclipse.org/bugs/show_bug.cgi?id=380314.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
ger...@googlecode.com  
View profile  
 More options Oct 16 2012, 5:35 pm
From: ger...@googlecode.com
Date: Tue, 16 Oct 2012 21:34:58 +0000
Local: Tues, Oct 16 2012 5:34 pm
Subject: Re: Issue 1374 in gerrit: Push Merge leads to files to be regarded as new

Comment #7 on issue 1374 by george...@gmail.com: Push Merge leads to files  
to be regarded as new
http://code.google.com/p/gerrit/issues/detail?id=1374

merge base is like CVS/SVN most recent *common* ancestor or parent. All  
merges can have one or more parents. A fast-forward merge has one parent. I  
am having RecursiveMerger reviewed after which we can change Gerrit to sue  
that merger instead of Resolve as a default. Then multiple base "Git"  
merges presented to Gerrit might look better.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »