Patches to Commit
0 views
Skip to first unread message
ironfroggy
Jun 18, 2008, 10:55:02 AM6/18/08
to geopy
OK, so we use geopy here (socialserve.com) and I was added as a
project member, but never have had the time to send my stuff upstream.
I want to take that opportunity, but first I wanted to lay out what
they involve, because I wouldn't feel right just committing things
willy nilly.
So, first of all, should I create a branch or branches to commit my
changes on for review?
Changes include:
- Replace print logging with use of the logging module.
- Creation of an Address class. basically an address tuple with names.
- GeocodeResult class. Compatible with the tuples in use now, but
provides location, latitude, and longitude attributes.
- Parsing of google results to get resulting address along with
coordinates.
- Understanding of the results accuracies, according to the source.
Most of this was done to get more information from the results,
including the cleaned street names and understanding how accurate the
resulting coordinates are. I'd like to get these in and put our
version matching geopy mainline.
project member, but never have had the time to send my stuff upstream.
I want to take that opportunity, but first I wanted to lay out what
they involve, because I wouldn't feel right just committing things
willy nilly.
So, first of all, should I create a branch or branches to commit my
changes on for review?
Changes include:
- Replace print logging with use of the logging module.
- Creation of an Address class. basically an address tuple with names.
- GeocodeResult class. Compatible with the tuples in use now, but
provides location, latitude, and longitude attributes.
- Parsing of google results to get resulting address along with
coordinates.
- Understanding of the results accuracies, according to the source.
Most of this was done to get more information from the results,
including the cleaned street names and understanding how accurate the
resulting coordinates are. I'd like to get these in and put our
version matching geopy mainline.
csenger
Aug 14, 2008, 10:40:03 AM8/14/08
to geopy
Hi,
On 18 Jun., 16:55, ironfroggy <ironfro...@gmail.com> wrote:
> OK, so we use geopy here (socialserve.com) and I was added as a
> project member, but never have had the time to send my stuff upstream.
> I want to take that opportunity, but first I wanted to lay out what
> they involve, because I wouldn't feel right just committing things
> willy nilly.
>
> So, first of all, should I create a branch or branches to commit my
> changes on for review?
[...]
I would like to test and use your changes, and found your patch from
Oktober 2008 in
files. It does not replace prints with logging. Is the patch up-to-
date? If not I would be happy
If you could upload one.
But event though I'm no project member I think that it's an svn-
repository and creating a branch
can't do harm. It's easier to track, review, merge parts into another
branch, and people can pull
a "working" version from there. So I would prefer a branch over a
patch.
..Carsten
On 18 Jun., 16:55, ironfroggy <ironfro...@gmail.com> wrote:
> OK, so we use geopy here (socialserve.com) and I was added as a
> project member, but never have had the time to send my stuff upstream.
> I want to take that opportunity, but first I wanted to lay out what
> they involve, because I wouldn't feel right just committing things
> willy nilly.
>
> So, first of all, should I create a branch or branches to commit my
> changes on for review?
I would like to test and use your changes, and found your patch from
Oktober 2008 in
files. It does not replace prints with logging. Is the patch up-to-
date? If not I would be happy
If you could upload one.
But event though I'm no project member I think that it's an svn-
repository and creating a branch
can't do harm. It's easier to track, review, merge parts into another
branch, and people can pull
a "working" version from there. So I would prefer a branch over a
patch.
..Carsten
csenger
Aug 14, 2008, 10:42:36 AM8/14/08
to geopy
> I would like to test and use your changes, and found your patch from
> Oktober 2008 in
2007
..Carsten
Lu Jik
Aug 21, 2008, 4:35:48 AM8/21/08
to geopy
I vote for putting these changes into a new branch, I would pull it
and test it. Once enough people are happy withit it could then me
merged with trunk.
and test it. Once enough people are happy withit it could then me
merged with trunk.
Reply all
Reply to author
Forward
0 new messages