Should we keep IModuleRule ?

0 views
Skip to first unread message

Sebastien Pouliot

unread,
Jan 24, 2008, 8:00:18 PM1/24/08
to Gendarme
since:

- we don't have any rule using it ?

- I can only think (from my notes) of one such rule, any other
candidates ?

- we could implement them, if required, from IAssemblyRule and and
iterating the Modules ?
(note: just like we need to do for rules about fields, from
ITypeRule)

- can be added back later if we really need it ;-)


p.s. I should be able to implement the I*Rule changes in Novell's next
hack week (February 11th week if memory serves) and hopefully a few
other features :)

Néstor Salceda

unread,
Jan 27, 2008, 8:17:07 AM1/27/08
to gend...@googlegroups.com
Hey !

Apologies for my late answer.


On jue, 2008-01-24 at 17:00 -0800, Sebastien Pouliot wrote:
> since:
>
> - we don't have any rule using it ?
>
> - I can only think (from my notes) of one such rule, any other
> candidates ?
>
> - we could implement them, if required, from IAssemblyRule and and
> iterating the Modules ?
> (note: just like we need to do for rules about fields, from
> ITypeRule)
>
> - can be added back later if we really need it ;-)

IMHO if there aren't any rule using it and we can add back it easily
later, we should remove IModuleRule. The code should be maintained and
if we don't use it, we haven't any reason for maintain it.

> p.s. I should be able to implement the I*Rule changes in Novell's next
> hack week (February 11th week if memory serves) and hopefully a few
> other features :)

This is perfect, the February 6th I will finish my exams and I will be
able to help you refactoring the rules and other related stuff :)

See you !

Néstor.

Sebastien Pouliot

unread,
Feb 1, 2008, 9:26:58 PM2/1/08
to Gendarme
Hey,

On Jan 27, 8:17 am, Néstor Salceda <nestor.salc...@gmail.com> wrote:
> This is perfect, the February 6th I will finish my exams and I will be
> able to help you refactoring the rules and other related stuff :)

This is gonna be a very fun week :)

Now go rock your exams! ;-)
Sebastien
Reply all
Reply to author
Forward
0 new messages