Model has Properties or Attributes?

[mistermojo]

Hi all,

This is a little tangential follow up from Eric Ponce's earlier question. In the docs (http://geddyjs.org/documentation#models.updateProperties), model seems to have .updateProperties() but in the generated (from "geddy resource foo" etc.) and working code, it's .updateAttributes().

Which do we want to be canonical? Either way is fine, but imho, we really should be more consistent. I'm guessing it's meant to be Properties since the other methods refer to properties. Changing the code in geddy and deployed apps would require "Search and Replace". So, if a change in geddy source is done, please do a "heads up" release notes post to the google group? Cheers!

[Joe Werle]

Very good point, I've been wondering the same thing. I think a convention and coding style doc would be cool.

--
The official community discussion group.
website: geddyjs.org, source: https://github.com/mde/geddy, group: https://groups.google.com/d/forum/geddyjs?hl=en
 
 

[Brent Westmoreland]

I think our fearless leader has posted the styleguide for all of his opensource projects here:

https://github.com/mde/js-styleguide

In addition the dotfiles for jslint, etc are posted here:

https://github.com/mde/dotfiles

+1 for properties over attributes

[Joe Werle]

+2 for an awesome timely response!

Thanks dude

werle

http://werle.io

@josephwerle

[mistermojo]

Strangely enough, I read (and largely agreed with) that style guide even before I tried geddy. Got to that doc from here: "https://github.com/mde/geddy/wiki/Contributing-to-Geddy" while I was shopping around for a node-based framework to use. Something about the style guide made me return to geddy. The project founder(s) seemed reasonable and thoughtful. :D

[Matthew Eernisse]

Yes, this should be updateProperties. I found an old reference to updateAttributes in the example app, and have updated it. I can't find it anywhere else. Looks like the docs on the site have it right.

[mistermojo]

Well, as of 0.6.13, if you do: 

geddy scaffold thingie

The generated code in app/controllers/thingies.js still has thingie.updateAttributes(params) in the this.update section.

Uh...also, something's broken in the scaffold code. I'll file a bug.

[mistermojo]

Update: it seems it does not like thingies. I tried with blob and it works. Have filed issue on github.

Anyway, scaffold still does generate updateAttributes(params) in the controller.

[Matthew Eernisse]

LOL inflections. :)

Ugh, looks like ack doesn't know about .ejs files. A proper "grep -r" found where that's happening. I'll push a fix ASAP.

[Matthew Eernisse]

Fix is in v0.6.14.

[mistermojo]

Thank you kindly!