Closing ResultSets When Not Selecting

[michael...@gmail.com]

Is there any need to close a resultset you're not selecting any rows?
It seems silly to have to assign the result of a database query to a
variable for the sole purpose of closing the resultset, but the docs
do not draw a distinction between resultsets from select operations
and update/delete operations.

[Scott Hess]

We've been thinking of this, witness:
http://code.google.com/p/google-gears/wiki/DatabaseHelpers

From the Gears level, there's really no way to know whether something
is going to return results or not - it's all SQL! An idiom which
should be safe to use for now would be something like:

db.execute("INSERT INTO t VALUES (?)", [x]).close();

This should be safe, if execute() completes, the ResultSet is closed.
If execute() has an error, it will throw an exception and a ResultSet
should never be generated.

-scott

[Scott Hess]

Aaron mentions that I'm subtley wrong.

If the statement succeeds but generates a result set which has no
columns, then the close() is called in execute(). You can close() it
again, but don't need to. So you should be able to safely drop
ResultSets from statements which only do data manipulation language
type statements. [I think this means anything but SELECT or PRAGMA
(which Gears disables) or EXPLAIN.]

Sorry for the misleading post.

-scott

[michael...@gmail.com]

Just to be 100% clear. You're saying that I do not need to close
ResultSets which do not SELECT rows?

-Mike

On Jul 16, 8:43 pm, "Scott Hess" <sh...@google.com> wrote:
> Aaron mentions that I'm subtley wrong.
>
> If the statement succeeds but generates a result set which has no
> columns, then the close() is called in execute(). You can close() it
> again, but don't need to. So you should be able to safely drop
> ResultSets from statements which only do data manipulation language
> type statements. [I think this means anything but SELECT or PRAGMA
> (which Gears disables) or EXPLAIN.]
>
> Sorry for the misleading post.
>
> -scott
>
> On 7/16/07, Scott Hess <sh...@google.com> wrote:
>

[Aaron Boodman]

On 7/16/07, michae...@google.com <michael...@gmail.com> wrote:

Just to be 100% clear. You're saying that I do not need to close
ResultSets which do not SELECT rows?

Yes, we close these ones for you before returning from execute().

- a

[michael...@gmail.com]

Thanks again!

On Jul 16, 11:17 pm, "Aaron Boodman" <a...@google.com> wrote: