Detecting DigiTech devices on startup and building debian package

[Ahmed Toulan]

Hi,

I was trying to build a debian package for Ubuntu. I managed to build
the package but thought that the package won't be usable unless we can
detect the device on startup ( also found this as a TODO item :) ) . I
managed to detect the device on startup.

This code actually allows us to detect available devices, which can
then be used to select the device from a combo box or something thus
eliminating the need for a command line argument. Currently it uses
the first device.

Here is the patch http://pastebin.com/bYhvXEzq
Please check it out and tell me your opinion. Sorry, I know that my C
is a little bit rusty and I have zero knowledge with glib :)

Regards,
Ahmed Toulan.

[Tomasz Moń]

On Sat, Sep 3, 2011 at 3:07 AM, Ahmed Toulan <theli...@gmail.com> wrote:
> Here is the patch http://pastebin.com/bYhvXEzq
> Please check it out and tell me your opinion. Sorry, I know that my C
> is a little bit rusty and I have zero knowledge with glib :)

Please submit unified diff.
Easiest way to do so, is to issue "hg diff" command from working copy
of gdigi repository.
Also, please attach the patch file to the email message.

Please use proper Doxygen format - that is, use the \return and \param
for all appropriate functions.

[Ahmed Toulan]

Hi Tomasz,

I followed your recommendations. Please check it now.

Regards,
Ahmed Toulan.

--
You received this message because you are subscribed to the Google Groups "gdigi" group.
To post to this group, send email to gd...@googlegroups.com.
To unsubscribe from this group, send email to gdigi+un...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/gdigi?hl=en.

[Ahmed Toulan]

Here is the latest patch with correct doxygen comments.

[Tomasz Moń]

On Mon, Sep 5, 2011 at 2:30 PM, Ahmed Toulan <theli...@gmail.com> wrote:
>> I followed your recommendations. Please check it now.

Please don't do top-posting on this mailing list.

I've modified your patch slightly - I think the user should be able to
explicitly give the port number, and only do the search if it's not
given at all.
If you think the modified patch is fine, I'll commit it.

[Ahmed Toulan]

--

You received this message because you are subscribed to the Google Groups "gdigi" group.
To post to this group, send email to gd...@googlegroups.com.
To unsubscribe from this group, send email to gdigi+un...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/gdigi?hl=en.

 

Sorry for top posting...

I can say that's much better. I was just starting to do the same myself based on a comment from Andrew Shadoura.
Thanks for accepting the patch.

Regards,
Ahmed Toulan.

[Tomasz Moń]

On Mon, Sep 5, 2011 at 5:43 PM, Ahmed Toulan <theli...@gmail.com> wrote:
> Sorry for top posting...

Quote only relevant information.

> I can say that's much better.

I've just commited it:
http://hg.atheme.org/users/desowin/gdigi/rev/5c53613a21fe