Review: Don't allow two new accounts on the same email.

0 views
Skip to first unread message

Henry Andrews

unread,
Nov 22, 2009, 9:58:53 PM11/22/09
to GGD Tech Group

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://dev.comics.org/reviews/r/241/
-----------------------------------------------------------

Review request for GGD Tech Group.


Summary
-------

*headdesk*

Let's just turn this off entirely. We don't really need it even for beta test anymore, especially as having two under the same email just means that your account acts really weird.


Diffs
-----

/branches/prototype/pydjango/apps/gcd/views/accounts.py 417

Diff: http://dev.comics.org/reviews/r/241/diff


Testing
-------

On production right now. The people who hit this have been notified directly and had their extra accounts deleted. There were only four, and one of them used an invalid email.


Thanks,

Henry

Ralf Haring

unread,
Nov 22, 2009, 10:29:09 PM11/22/09
to GGD Tech Group

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://dev.comics.org/reviews/r/241/#review523
-----------------------------------------------------------

Ship it!


- Ralf


On 2009-11-22 18:58:53, Henry Andrews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://dev.comics.org/reviews/r/241/
> -----------------------------------------------------------
>
> (Updated 2009-11-22 18:58:53)
Reply all
Reply to author
Forward
0 new messages