Review Board trouble

[Alexandros Diamantidis]

I updated the code from http://reviews.comics.org/r/1027/ and tried to
post a new diff for review (from the gcd-django repo). That gave the
message:

>>> Got API Error 105 (HTTP code 400): One or more fields had errors
>>> Error data: {u'fields': {u'basedir': [u'This field is required.']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}}

So, I thought maybe it's because the review was created from SVN and now
we've moved to git. But trying to do a new "post-review" I got:

> There was an error creating this review request.
>
> The repository path "https://github.com/GrandComicsDatabase/gcd-django"
> is not in the list of known repositories on the server.
>
> Ask the administrator to add this repository to the Review Board server.
> For information on adding repositories, please read
> http://www.reviewboard.org/docs/manual/dev/admin/configuration/repositories/

Any ideas?

Thanks!
Alexandros

[Henry Andrews]

Did you update your local RBTools package to match versions?  If you're using a really old post-review, it probably won't work.

-henry

---

From: Alexandros Diamantidis <ad...@hellug.gr>
To: gcd-...@googlegroups.com
Sent: Thursday, October 4, 2012 6:21 PM
Subject: [gcd-tech] Review Board trouble

--
GCD-Tech mailing list - gcd-...@googlegroups.com
To unsubscribe send email to gcd-tech+unsub...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/gcd-tech

[Alexandros Diamantidis]

* Henry Andrews [2012-10-04 21:05]:

> Did you update your local RBTools package to match versions? �If you're using a really old post-review, it probably won't work.

I did, in fact Gentoo has RBTools 0.4.2 (the latest one) as a package. I
just noticed a problem in "post-review --debug" output:

DEBUG:root:repository info: Path: https://github.com/GrandComicsDatabase/gcd-django, Base path: , Supports changesets: False

That is, it sees an empty base path. Maybe it gets confused because
under SVN it used to be /pydjango while now it should be /.

Jochen suggested off-list that since I based the review on SVN, I could
post the new update from SVN as well, so I just did that.

I'll test again posting a review from a git clone when I have something
new ;-)

Thanks!

Alexandros

[Jochen G.]

try

git://github.com/GrandComicsDatabase/gcd-django.git

Jochen

[Jochen G.]

https is fixed.

review-board seems to reset to git:// in the admin instead of keeping
the https:// for github if one edits that setting...

Jochen

[Jochen G.]

Hmm, https only works partly.

so we need to clone from git:// and not https:// for now

Jochen

[Alexandros Diamantidis]

* Jochen G. [2012-10-05 17:22]:
> try
>
> git://github.com/GrandComicsDatabase/gcd-django.git

OK, with the remote origin repo set to that, posting a new review
request works fine. I still can't update the existing request that
was opened with SVN, so I'll update it from SVN.

Thanks for your patience!

Alexandros

[Henry Andrews]

Review Board scopes reviews to repositories, so you'll never be able to mix repos (from any tool) on a single review.

-henry

---

From: Alexandros Diamantidis <ad...@hellug.gr>
To: gcd-...@googlegroups.com

Sent: Saturday, October 6, 2012 5:09 PM
Subject: Re: [gcd-tech] Review Board trouble