[Bug 686] New: Add keywords

48 views
Skip to first unread message

GCD Tech Bugs

unread,
Aug 12, 2011, 7:30:46 PM8/12/11
to gcd-...@googlegroups.com
http://dev.comics.org/bugs/show_bug.cgi?id=686

Web Browser: ---
Summary: Add keywords
Product: GCD Online
Version: 0.6 kin-der-kids
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P3
Component: model
AssignedTo: gcd-...@googlegroups.com
ReportedBy: lio...@beanmar.net
Estimated Hours: 0.0


Add keywords to publisher, series, issue, and content. Indexers should be able
to add keywords at any of these levels, and users should be able to search
them.


--
Configure bugmail: http://dev.comics.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

GCD Tech Bugs

unread,
Aug 12, 2011, 7:33:28 PM8/12/11
to gcd-...@googlegroups.com
http://dev.comics.org/bugs/show_bug.cgi?id=686

--- Comment #1 from Lionel English <lio...@beanmar.net> 2011-08-13 01:48:51 PST ---
Presumably we will probably also want to add them to other tables, such as
creators, characters, and features when those are created.

Design question: Is it better (and, if so, in what way(s)?) to implement as
fields in each relevant table, or to implement them in their own table, linked
to the other tables?

GCD Tech Bugs

unread,
Aug 25, 2011, 12:24:09 AM8/25/11
to gcd-...@googlegroups.com
http://dev.comics.org/bugs/show_bug.cgi?id=686


Lionel English <lio...@beanmar.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Blocks| |691

GCD Tech Bugs

unread,
Nov 26, 2011, 10:33:58 AM11/26/11
to gcd-...@googlegroups.com
http://dev.comics.org/bugs/show_bug.cgi?id=686


Jochen Garcke <gcd...@garcke.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |gcd...@garcke.de
Version|0.6 kin-der-kids |-.- future


--- Comment #2 from Jochen Garcke <gcd...@garcke.de> 2011-11-26 16:52:53 PST ---
the design questions still need to be answered, before that no work on this
possible

GCD Tech Bugs

unread,
Nov 28, 2011, 1:24:10 PM11/28/11
to gcd-...@googlegroups.com
http://dev.comics.org/bugs/show_bug.cgi?id=686

--- Comment #3 from Lionel English <lio...@beanmar.net> 2011-11-28 19:43:22 PST ---
Are you referring to the design questions I raised in the first comment? If
so, I see those as tech questions--what design do we think will be best?
Implementation details will presumably be invisible to the end-user.

If there are policy questions that need to be addressed, let me know.

GCD Tech Bugs

unread,
Nov 28, 2011, 2:08:31 PM11/28/11
to gcd-...@googlegroups.com
http://dev.comics.org/bugs/show_bug.cgi?id=686

--- Comment #4 from Jochen Garcke <gcd...@garcke.de> 2011-11-28 20:27:44 PST ---
It is not a policy question, but neither a tech question.

For example it involves how searches should work. What do we expect from a
keyword field in that regard ? Should a search for keyword find all occurences,
independent of publisher, series, issue, and content ? Or should a keyword
search be an additional thing for a publisher, series, issue, and content
search ?

These need to be addressed somehow by someone.

GCD Tech Bugs

unread,
Feb 8, 2012, 12:53:05 AM2/8/12
to gcd-...@googlegroups.com
http://dev.comics.org/bugs/show_bug.cgi?id=686

--- Comment #5 from Lionel English <lio...@beanmar.net> 2012-02-08 07:14:43 PST ---
OK, I'm going to make an executive decision on this one.

We should add a new field, keyword, to each of the major object tables--master
publisher, indicia publisher, publisher brand, series, issue, story. We should
also add it to future major object tables as they're added--e.g. creators,
characters, strips, etc.

The search questions can be deferred for a few months till we get Solr
integrated.

Jochen G.

unread,
Feb 8, 2012, 4:45:06 AM2/8/12
to gcd-...@googlegroups.com
If someone can write for keywords

a) a short help text which shows on the OI editing screens (mostly a
sentence or two for the existing ones)
b) a wiki page which a longer description which we can link to from the OI

When these are done I can add the field to the db-tables, OI and
advanced search.

Jochen

GCD Tech Bugs

unread,
Feb 9, 2012, 3:01:00 PM2/9/12
to gcd-...@googlegroups.com
http://dev.comics.org/bugs/show_bug.cgi?id=686


Jochen Garcke <gcd...@garcke.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|gcd-...@googlegroups.com |gcd...@garcke.de
Status|NEW |ASSIGNED


--- Comment #6 from Jochen Garcke <gcd...@garcke.de> 2012-02-09 21:22:40 PST ---
Do we want to limit the length of the keyword field ? As in having a max number
of chars ?

GCD Tech Bugs

unread,
Feb 9, 2012, 3:01:10 PM2/9/12
to gcd-...@googlegroups.com
http://dev.comics.org/bugs/show_bug.cgi?id=686


Jochen Garcke <gcd...@garcke.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
Version|-.- future |0.6 kin-der-kids

GCD Tech Bugs

unread,
Feb 10, 2012, 2:35:57 PM2/10/12
to gcd-...@googlegroups.com
http://dev.comics.org/bugs/show_bug.cgi?id=686


Jochen Garcke <gcd...@garcke.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|gcd...@garcke.de |gcd-...@googlegroups.com
Status|ASSIGNED |NEW


--- Comment #7 from Jochen Garcke <gcd...@garcke.de> 2012-02-10 20:57:39 PST ---
Need to investigate use of
https://github.com/alex/django-taggit

and dozens of extensions, e.g.
http://charlesleifer.com/blog/suggesting-tags-django-taggit-and-jquery-ui/
http://birdhouse.org/software/2011/05/django-taggit/

Won't have time to look into this in the next weeks so I'll unassign this.

Shouldn't be too problematic though, and since this probably doesn't tackle the
core codebase too much people interested could use this as a starting project.

GCD Tech Bugs

unread,
Feb 10, 2012, 2:37:33 PM2/10/12
to gcd-...@googlegroups.com
http://dev.comics.org/bugs/show_bug.cgi?id=686

--- Comment #8 from Jochen Garcke <gcd...@garcke.de> 2012-02-10 20:59:15 PST ---
suggested help for the OI:

significant objects, locations, events, or themes (NOT characters) depicted in
the content, such as "Phantom Zone," "red kryptonite," "Vietnam," or "time
travel." Multiple entries are to be separated by semi-colons.

for the wiki:
keywords

optional

a list of significant objects, locations, events, themes, etc that are depicted
in the contents of the sequence.

Characters or portrayals of real persons are not included here. Those are
listed in the characters field.

examples:
Batcave
Wand of Watoomb
Nazis
Cold War
French Revolution
Latveria
snow
golf

GCD Tech Bugs

unread,
Mar 22, 2012, 4:05:33 AM3/22/12
to gcd-...@googlegroups.com
http://dev.comics.org/bugs/show_bug.cgi?id=686


Jochen G. <gcd...@garcke.de> changed:

What |Removed |Added
----------------------------------------------------------------------------


AssignedTo|gcd-...@googlegroups.com |gcd...@garcke.de
Status|NEW |ASSIGNED

GCD Tech Bugs

unread,
Apr 10, 2012, 2:26:51 PM4/10/12
to gcd-...@googlegroups.com
http://dev.comics.org/bugs/show_bug.cgi?id=686


Jochen G. <gcd...@garcke.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED


--- Comment #9 from Jochen G. <gcd...@garcke.de> 2012-04-10 20:26:03 PST ---
http://reviews.comics.org/r/999/

Reply all
Reply to author
Forward
0 new messages