Review Request: small change to have dev-server work with generic images - gcd-tech

The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Message from discussion Review Request: small change to have dev-server work with generic images
Received-SPF: pass (google.com: domain of nore...@reviews.comics.org designates 78.47.60.187 as permitted sender) client-ip=78.47.60.187;
Content-Type: multipart/alternative;
 boundary="===============6814344547132415992=="
MIME-Version: 1.0
Subject: Review Request: small change to have dev-server work with generic images
From: "Jochen G." <gcdm...@garcke.de>
To: "GCD Tech Group" <gcd-tech@googlegroups.com>,
 "Jochen G." <gcdm...@garcke.de>
Date: Wed, 03 Oct 2012 15:49:46 -0000
Message-ID: <20121003154946.18089.68334@web0.comics.org>
Auto-Submitted: auto-generated
Sender: "Jochen G." <nore...@reviews.comics.org>
Reply-To: "Jochen G." <gcdm...@garcke.de>

--===============6814344547132415992==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.comics.org/r/1035/
-----------------------------------------------------------

Review request for GCD Tech Group.


Description
-------

If one uses a current copy of the db with the new generic images it fails i=
n one case with an error (the other errors are silent in the templates...)

Also testing the github setup together with Review Board.


Diffs
-----

  apps/gcd/views/covers.py 04558195fed9808f2012e43271e8458bf8097a8c =

  templates/gcd/details/issue_images.html e7029a48ca2e9dceaf6b5f5bb475aaff5=
95f75de =


Diff: http://reviews.comics.org/r/1035/diff/


Testing
-------


Thanks,

Jochen G.


--===============6814344547132415992==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable




<html>
 <body>
  <div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href=3D"http://reviews.comics.org/r/1035/">http://reviews.comics.o=
rg/r/1035/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://reviews.comics.org/media/rb/image=
s/review_request_box_top_bg.png'); background-position: left top; backgroun=
d-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for GCD Tech Group.</div>
<div>By Jochen G..</div>







<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
 <table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">If one uses a current copy of the db with the new generic im=
ages it fails in one case with an error (the other errors are silent in the=
 templates...)

Also testing the github setup together with Review Board.</pre>
  </td>
 </tr>
</table>





<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
 </h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">

 <li>apps/gcd/views/covers.py <span style=3D"color: grey">(04558195fed9808f=
2012e43271e8458bf8097a8c)</span></li>

 <li>templates/gcd/details/issue_images.html <span style=3D"color: grey">(e=
7029a48ca2e9dceaf6b5f5bb475aaff595f75de)</span></li>

</ul>

<p><a href=3D"http://reviews.comics.org/r/1035/diff/" style=3D"margin-left:=
 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============6814344547132415992==--
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
Account Options
