Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Message from discussion Review Request: Allow disabling Google ads and Calendar
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Jochen G.  
View profile  
 More options Nov 27 2011, 1:10 pm
From: "Jochen G." <gcdm...@garcke.de>
Date: Sun, 27 Nov 2011 18:10:28 -0000
Local: Sun, Nov 27 2011 1:10 pm
Subject: Re: Review Request: Allow disabling Google ads and Calendar

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.comics.org/r/956/#review2051
-----------------------------------------------------------

Ship it!

- Jochen

On 2011-11-27 15:42:30, Henry Andrews wrote:

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.comics.org/r/956/
> -----------------------------------------------------------

> (Updated 2011-11-27 15:42:30)

> Review request for GGD Tech Group.

> Summary
> -------

> The google ads increase page load time and generally are a nuisance in a local copy.  The calendar is less of a nuisance, but still slows things down.  This allows turning each of them off independently.  If there's a reason not to do this I can just keep this as a local modification for myself, but it seemed helpful :-)

> Diffs
> -----

>   /pydjango/settings.py 1332
>   /pydjango/templates/gcd/bits/google.html 1332
>   /pydjango/templates/gcd/details/issue.html 1332
>   /pydjango/templates/gcd/index.html 1332

> Diff: http://reviews.comics.org/r/956/diff

> Testing
> -------

> Ran with this while testing the datatables thing.

> Thanks,

> Henry


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.