Review Request: Allow disabling Google ads and Calendar

Henry Andrews

unread,

Nov 27, 2011, 10:42:30 AM11/27/11

to GGD Tech Group, Henry Andrews

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.comics.org/r/956/
-----------------------------------------------------------

Review request for GGD Tech Group.

Summary
-------

The google ads increase page load time and generally are a nuisance in a local copy. The calendar is less of a nuisance, but still slows things down. This allows turning each of them off independently. If there's a reason not to do this I can just keep this as a local modification for myself, but it seemed helpful :-)

Diffs
-----

/pydjango/settings.py 1332
/pydjango/templates/gcd/bits/google.html 1332
/pydjango/templates/gcd/details/issue.html 1332
/pydjango/templates/gcd/index.html 1332

Diff: http://reviews.comics.org/r/956/diff

Testing
-------

Ran with this while testing the datatables thing.

Thanks,

Henry

Jochen G.

unread,

Nov 27, 2011, 1:10:28 PM11/27/11

to GGD Tech Group, Jochen G., Henry Andrews

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:

http://reviews.comics.org/r/956/#review2051
-----------------------------------------------------------

Ship it!

- Jochen

On 2011-11-27 15:42:30, Henry Andrews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.comics.org/r/956/
> -----------------------------------------------------------
>

> (Updated 2011-11-27 15:42:30)

Lionel English

unread,

Dec 1, 2011, 12:46:01 AM12/1/11

to GGD Tech Group, Lionel English, Henry Andrews

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:

http://reviews.comics.org/r/956/#review2064
-----------------------------------------------------------

Ship it!

- Lionel

On 2011-11-27 15:42:30, Henry Andrews wrote:
>

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.comics.org/r/956/
> -----------------------------------------------------------
>

> (Updated 2011-11-27 15:42:30)
>
>

Lionel English

unread,

Dec 5, 2011, 1:31:32 AM12/5/11

to GGD Tech Group, Lionel English, Henry Andrews

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:

http://reviews.comics.org/r/956/#review2066
-----------------------------------------------------------

Ship it!

- Lionel

On 2011-11-27 15:42:30, Henry Andrews wrote:
>

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.comics.org/r/956/
> -----------------------------------------------------------
>

> (Updated 2011-11-27 15:42:30)
>
>

Lionel English

unread,

Feb 29, 2012, 1:05:42 AM2/29/12

to GGD Tech Group, Lionel English, Henry Andrews

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:

http://reviews.comics.org/r/956/#review2089
-----------------------------------------------------------

Ship it!

- Lionel

On 2011-11-27 15:42:30, Henry Andrews wrote:
>

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.comics.org/r/956/
> -----------------------------------------------------------
>

> (Updated 2011-11-27 15:42:30)
>
>

Jochen G.

unread,

Apr 23, 2012, 6:10:09 PM4/23/12

to GGD Tech Group, Jochen G., Henry Andrews

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:

http://reviews.comics.org/r/956/#review2093
-----------------------------------------------------------

This change totally turned off all our ads. The 'settings' variable is not passed through to a template by default ! Should do this like BETA in the same backend I guess and use ADVERTISING without the settings. then.

- Jochen

On 2011-11-27 15:42:30, Henry Andrews wrote:
>

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.comics.org/r/956/
> -----------------------------------------------------------
>

> (Updated 2011-11-27 15:42:30)
>
>

Henry Andrews

unread,

Apr 23, 2012, 7:05:57 PM4/23/12

to GGD Tech Group, Jochen G., Henry Andrews

> On 2012-04-23 22:10:09, Jochen G. wrote:
> > This change totally turned off all our ads. The 'settings' variable is not passed through to a template by default ! Should do this like BETA in the same backend I guess and use ADVERTISING without the settings. then.

Ooops- sorry :-( Yeah, that makes sense.

- Henry

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.comics.org/r/956/#review2093
-----------------------------------------------------------

Reply all

Reply to author

Forward