Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
gcd-tech
Home
About this group
Apply for group membership
Review Request: add generic image support
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   1 message - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Jochen G.  
View profile  
 More options Aug 11 2012, 4:48 pm
From: "Jochen G." <gcdm...@garcke.de>
Date: Sat, 11 Aug 2012 20:48:30 -0000
Local: Sat, Aug 11 2012 4:48 pm
Subject: Review Request: add generic image support
Print | Individual message | Show original | Report this message | Find messages by this author

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.comics.org/r/1025/
-----------------------------------------------------------

Review request for GGD Tech Group.

Summary
-------

These are the model changes and the OI code to allow a generic image handling. An image can be associated to any other object. We control which kind of relationships we allow in the OI, this is done via an ImageType model where we set things up.

On the objects we can (but don't need to) add properties to access the images. If there would be only one kind of picture per object, one could do that as a reverse generic relation, but the queries would be the same anyway. And this way, we can filter out deleted images directly without a second step.

The OI code is based to a big degree on the cover code. But we are using now the ImageField model, which makes processing and saving of images easier. Also we use the external ImageKits library, which makes generating other sizes on the fly (with cache) very easy.

Added data for indicia and statement of ownership for issues. Can do similar things for other objects, mainly thinking of brands at this stage.

The display code will follow later.

Diffs
-----

  /pydjango/apps/oi/covers.py 1482
  /pydjango/apps/oi/forms.py 1482
  /pydjango/apps/oi/models.py 1482
  /pydjango/apps/oi/urls.py 1482
  /pydjango/apps/oi/views.py 1482
  /pydjango/apps/gcd/models/issue.py 1482
  /pydjango/apps/gcd/views/covers.py 1482
  /pydjango/apps/gcd/fixtures/imagetype.yaml PRE-CREATION
  /pydjango/apps/gcd/models/__init__.py 1482
  /pydjango/apps/gcd/models/image.py PRE-CREATION
  /pydjango/settings.py 1482
  /pydjango/templates/oi/edit/compare_cover.html 1482
  /pydjango/templates/oi/edit/compare_image.html PRE-CREATION
  /pydjango/templates/oi/edit/upload_image.html PRE-CREATION

Diff: http://reviews.comics.org/r/1025/diff

Testing
-------

Tested locally, will put on beta for testing once the display code is finished.

Thanks,

Jochen


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google