Review Request: further fixes to cover upload/compare

1 view
Skip to first unread message

Jochen G.

unread,
Aug 10, 2011, 4:38:57 PM8/10/11
to GGD Tech Group, Jochen G.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.comics.org/r/896/
-----------------------------------------------------------

Review request for GGD Tech Group.


Summary
-------

hopefully last missing situation. Variants can also have uploads, so for these the pending stuff and other covers from the base should also show, both on upload and compare.

since now current_covers can't be used as a conditional anymore give a kwargs to the template to show correct info text.

Also some other fixes, where I learned something new about python. kwargs={} is not set to {}, but to a mutable dict, so its content can stay...


Diffs
-----

/pydjango/apps/oi/views.py 1223
/pydjango/apps/oi/covers.py 1223
/pydjango/templates/oi/edit/compare_cover.html 1223

Diff: http://reviews.comics.org/r/896/diff


Testing
-------

it fixes some problems (the kwargs one kind of bad one), so I'll commit and put on production


Thanks,

Jochen

Reply all
Reply to author
Forward
0 new messages