Merging imprint deletes to trunk

[Henry Andrews]

Hi folks,
I'd like to merge the imprint deletion support, along with a migration script
to trigger the deletion of the imprints already at zero and set their counts
correctly (as deployed on beta this is all messed up and causes the imprint
deletion not to work properly). I'd like to do this because it does not require
a database change other than the count script, and the count script can be run
with minimal or no downtime (we might want to make it read-only while the script
runs, but it should be pretty quick- not like the migrations where we alter
table structure).

I'd like to do this because part of the problem with 0.4 little nemo was that
so much funcitonality got hung up on the big deliverables. I'd like to shove
some stuff out before I start making table changes for publisher improvements
and Jochen starts doing similar things for issue variants.

Thoughts? Objections?

thanks,
-henry

[Lionel English]

Sounds reasonable.

--
GCD-Tech mailing list - gcd-...@googlegroups.com
To unsubscribe send email to gcd-tech+u...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/gcd-tech

--
Lionel English

San Diego, CA
lio...@beanmar.net

[Jochen Garcke]

The deletion had no real beta testing till now (besides by myself), this
should take place before any deployment. For enough imprints (where the
counts are OK) this can be tested on beta.

My goal for issue versions is still May.
Once I am back home next week I am going to call for more beta testing
of that, till now that was a bit limited in people responding. And
someone could have a go at the code review.

What functionality do you intend to work on and in what time frame ?

Jochen

[Henry Andrews]

I've been poking at it on beta. It's currently hard to test b/c the counts are
so messed up, hence a migration script before doing anything else. I'm working
various publisher changes as discussed on the lists elsewhere- I'll try to sum
it up this weekend. I'll work around your schedule one way or the other.
There's still no need aside from completing beta testing for this to wait until
may.

-henry

[Jochen Garcke]

Am 13.04.2011 06:26, schrieb Henry Andrews:
> I've been poking at it on beta. It's currently hard to test b/c the counts are
> so messed up

Just pick an imprint with only one or two series attached...

A migration script we need as well

Jochen

[Henry Andrews]

Yes, yes I figured that out. It seems to work fine, but there are some really
odd situations on there with out-of-sync counts. I want to get them out of the
picture before calling it solid.

[Jochen Garcke]

Which is why a count reset script and delete script for imprints with
zero counts is on my list of things to do (or already partly done, can't
remember)...

Jochen

[Henry Andrews]

If you have it please post it or wrap it up. I was going to write it since I
want to get this out of the way before I move on to other publisher related
things and I could not remember when you were coming back.

[Henry Andrews]

Will try to come back with a full plan this weekend, and also take a look at the
variant code review. It would really be so much more helpful if you could break
things up into smaller reviews. These massive changes are just brutal (and yes,
I know I've done my share but I think I've been fairly successful in avoiding it
recently). Although maybe it's not as bad as it looks- I wasn't up to even
letting it load all the files today (just got off the airplane, need sleep).

thanks,
-henry

----- Original Message ----
> From: Jochen Garcke <gcd...@garcke.de>
> To: gcd-...@googlegroups.com
> Sent: Tue, April 12, 2011 5:56:19 AM
> Subject: Re: [gcd-tech] Merging imprint deletes to trunk
>