Issue 934 in gbif-providertoolkit: Minor styling bugs in 2.0.4

[gbif-provi...@googlecode.com]

Status: Accepted
Owner: ----
CC: b...@gbif.org
Labels: Type-Defect Styling-Issue Milestone-Release2.0.5

New issue 934 by kyle.br...@gmail.com: Minor styling bugs in 2.0.4
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

Please use this issue to report any styling errors encountered in the 2.0.4
version of the IPT. Thanks

[gbif-provi...@googlecode.com]

Updates:
Cc: daniel.amariles88

Comment #1 on issue 934 by kyle.br...@gmail.com: Minor styling bugs in 2.0.4
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

Transferred from Issue 878: Comment 104 by project member
daniel.amariles88, Oct 26 (2 days ago)

Problems in Source Data page
* not showing preview button
* delete button is shown too lower

Tested in
IPT Version 2.0.5-SNAPSHOT-r4235
IPT Version 2.0.4 (tag version)

It happens
Chrome 22.0.1229.94 m for Windows


Doesn't happen in
Chrome 20.0.1132.57 for MacOSX
Firefox 14.0.1 for MacOSX
Firefox 16.0.1 for Windows

Please note: this could be related with issue 933

Attachments:
erroript.png 131 KB
erroript2.png 99 KB

[gbif-provi...@googlecode.com]

Comment #2 on issue 934 by daniel.amariles88: Minor styling bugs in 2.0.4
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

Our webdesigner Carlos
suggested to change some lines of the css

currently the style have this:

.buttons{
height:25px;
margin-top:10px;
float:left;
}


and the suggestion is set following lines:

.buttons{
margin-top:10px;
float:left;
min-width:200px;
}

thanks

[gbif-provi...@googlecode.com]

Updates:
Status: Started

Comment #4 on issue 934 by kyle.br...@gmail.com: Minor styling bugs in 2.0.4
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

Thanks for the contribution. After testing browsers on OS X I found no
errors with the way buttons render and committed it in r4237.

I will need your help testing browsers on Windows, would that be possible?

[gbif-provi...@googlecode.com]

Comment #5 on issue 934 by kyle.br...@gmail.com: Minor styling bugs in 2.0.4

http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

Thanks for the contribution. After testing browsers on OS X I found no
errors with the way buttons render and committed it in r4237.

I will need your help testing browsers on Windows, to see if buttons
render, and if Issue 933 has been solved as a result of the change... would
that be possible? Many thanks

[gbif-provi...@googlecode.com]

Comment #6 on issue 934 by kyle.br...@gmail.com: Minor styling bugs in 2.0.4
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

*Transferred comment by s.cozijnsen made in
http://code.google.com/p/gbif-providertoolkit/source/detail?r=4238 to this
issue:

/trunk/gbif-ipt/src/main/webapp/WEB-INF/pages/portal/home.ftl r4238
line 52:
52: ${r.coreType?upper_case}

Suggestion: change ${r.coreType?upper_case} to ${r.coreType?lower_case} and
handle the styling in the main.css.

table td#resourceType, table td#resourceSubType {
text-transform: uppercase;
}

The reason for this would be that you can also choose "capitalize" so that
all the columns have the same styling. (see: http://ipt.nlbif.nl )

/trunk/gbif-ipt/src/main/webapp/WEB-INF/pages/portal/home.ftl r4238
line 59:
59: ${r.subtype?upper_case?substring(0,7)}${dotDot}

Suggestion: change ${r.subtype?upper_case?substring(0,7)}${dotDot} to
${r.subtype?lower_case?substring(0,7)}${dotDot} and handle the styling in
the main.css.

Same reason as described earlier.

Sijmen

[gbif-provi...@googlecode.com]

Comment #8 on issue 934 by daniel.amariles88: Minor styling bugs in 2.0.4
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

sorry for the delay

we tested, and still being a difference between chrome and firefox
the "Delete source file" button appears a line above the "Save"
and "Cancel" buttons
(see screenshots)

Attachments:
firefox934.png 106 KB
chrome934.png 100 KB

[gbif-provi...@googlecode.com]

Updates:
Owner: kyle.br...@gmail.com
Labels: Priority-Medium

Comment #9 on issue 934 by kyle.br...@gmail.com: Minor styling bugs in 2.0.4
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

Daniel, any patches from your styling experts are more than welcome. Please
report any additional styling problems if you find them. Thanks.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[gbif-provi...@googlecode.com]

Comment #10 on issue 934 by daniel.amariles88: Minor styling bugs in 2.0.4
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

with changes specified in comment #2 we fixed in our fork the specified in
comment #8

styling enhancements may be adopted from our repository
we sugest to checkout our green version trunk/verde-ipt-2.0.4
http://code.google.com/p/sib-ipt/source/browse/#svn%2Ftrunk%2Fverde-ipt-2.0.4
please, feel free to use anything there

[gbif-provi...@googlecode.com]

Comment #11 on issue 934 by daniel.amariles88: Minor styling bugs in 2.0.4
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

I suggest to use our administration icons (see attachment) shared in
repository shared in comment 10

Attachments:
Captura de pantalla 2013-04-09 a la(s) 17.39.43.png 182 KB

[gbif-provi...@googlecode.com]

Comment #12 on issue 934 by daniel.amariles88: Minor styling bugs in 2.0.4
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

I suggest to change the marker icon from geocoverage page
by setting in geocoverage.ftl a local image path in the "markerIcon"
variable, like:
var markerIcon = '../images/icons/dot.png';
and adding adding a nicer image for marker (see attachment downloaded from
Maki http://mapbox.com/maki/)



Attachments:
marker-24.png 678 bytes

[gbif-provi...@googlecode.com]

Comment #13 on issue 934 by daniel.amariles88: Minor styling bugs in 2.0.4
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

another suggestion is to change the language selection menu, to show the
name of the language instead of the flags of a single country, see
attachment.

Attachments:
Captura de pantalla 2013-04-10 a la(s) 14.35.53.png 32.5 KB

[gbif-provi...@googlecode.com]

Comment #14 on issue 934 by b...@gbif.org: Minor styling bugs in 2.0.4
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

Daniel - the suggestion looks cool!
About the language selector, there is a separate issue that I'd like to
bring to the attention of issue-subscribers.
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=729

[gbif-provi...@googlecode.com]

Comment #16 on issue 934 by kyle.br...@gmail.com: Minor styling bugs in
2.0.4
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

New admin icons added as per suggestion. See screenshot. Main colors made
consistent across pages. See 2nd screenshot.

Attachments:
Screen Shot 2013-05-14 at 11.54.12 AM.png 85.6 KB
Screen Shot 2013-05-14 at 11.54.02 AM.png 85.5 KB

[gbif-provi...@googlecode.com]

Updates:
Status: Verified

Comment #17 on issue 934 by kyle.br...@gmail.com: Minor styling bugs in
2.0.4
http://code.google.com/p/gbif-providertoolkit/issues/detail?id=934

I don't intend on making further changes to the style now. New issues can
be opened up agains 2.0.5 when it is released.

Verified.