[PATCH master] confd: fix RpcVersion call

10 views
Skip to first unread message

Iustin Pop

unread,
Oct 15, 2012, 3:54:14 PM10/15/12
to ganeti...@googlegroups.com, Iustin Pop
From: Iustin Pop <ius...@google.com>

By accident, we sent the node object as call data in this rpc call,
instead the version request (i.e. nothing). This is due to the fact
that the 'call' data comes second, not first in the function argument.

Signed-off-by: Iustin Pop <ius...@google.com>
---
htools/Ganeti/Rpc.hs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htools/Ganeti/Rpc.hs b/htools/Ganeti/Rpc.hs
index b46b3ba..e0007c8 100644
--- a/htools/Ganeti/Rpc.hs
+++ b/htools/Ganeti/Rpc.hs
@@ -387,7 +387,7 @@ instance RpcCall RpcCallVersion where
rpcCallName _ = "version"
rpcCallTimeout _ = rpcTimeoutToRaw Urgent
rpcCallAcceptOffline _ = True
- rpcCallData call _ = J.encode [call]
+ rpcCallData _ = J.encode

instance Rpc RpcCallVersion RpcResultVersion where
rpcResultFill _ res = fromJSValueToRes res RpcResultVersion
--
1.7.10.4

Agata Murawska

unread,
Oct 15, 2012, 4:02:31 PM10/15/12
to Iustin Pop, ganeti...@googlegroups.com, Iustin Pop
2012/10/15 Iustin Pop <iu...@k1024.org>:
Oops ;) LGTM!
Reply all
Reply to author
Forward
0 new messages