Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
confd: fix RpcVersion call
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Iustin Pop  
View profile  
 More options Oct 15 2012, 3:54 pm
From: Iustin Pop <iu...@k1024.org>
Date: Mon, 15 Oct 2012 21:54:14 +0200
Local: Mon, Oct 15 2012 3:54 pm
Subject: [PATCH master] confd: fix RpcVersion call
From: Iustin Pop <ius...@google.com>

By accident, we sent the node object as call data in this rpc call,
instead the version request (i.e. nothing). This is due to the fact
that the 'call' data comes second, not first in the function argument.

Signed-off-by: Iustin Pop <ius...@google.com>
---
 htools/Ganeti/Rpc.hs |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htools/Ganeti/Rpc.hs b/htools/Ganeti/Rpc.hs
index b46b3ba..e0007c8 100644
--- a/htools/Ganeti/Rpc.hs
+++ b/htools/Ganeti/Rpc.hs
@@ -387,7 +387,7 @@ instance RpcCall RpcCallVersion where
   rpcCallName _          = "version"
   rpcCallTimeout _       = rpcTimeoutToRaw Urgent
   rpcCallAcceptOffline _ = True
-  rpcCallData call _     = J.encode [call]
+  rpcCallData _          = J.encode

 instance Rpc RpcCallVersion RpcResultVersion where
   rpcResultFill _ res = fromJSValueToRes res RpcResultVersion
--
1.7.10.4


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Agata Murawska  
View profile  
 More options Oct 15 2012, 4:02 pm
From: Agata Murawska <ayertie...@gmail.com>
Date: Mon, 15 Oct 2012 22:02:31 +0200
Local: Mon, Oct 15 2012 4:02 pm
Subject: Re: [PATCH master] confd: fix RpcVersion call
2012/10/15 Iustin Pop <iu...@k1024.org>:

Oops ;) LGTM!

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »