Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Funtoo
Home
+ new post
About this group
Join this group
Message from discussion Github tarballs (was: localpatch() fails if $S initially has a bogus value)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Piotr Karbowski  
View profile  
 More options Feb 2 2011, 4:16 am
From: Piotr Karbowski <jabberu...@gmail.com>
Date: Wed, 02 Feb 2011 10:16:29 +0100
Local: Wed, Feb 2 2011 4:16 am
Subject: Re: [funtoo] Github tarballs (was: localpatch() fails if $S initially has a bogus value)
Print | View thread | Show original | Report this message | Find messages by this author
On 01/31/2011 02:29 AM, Jonas Bernoulli wrote:

> If there are other cases but the github problem where $S is not fixed
> before localpatch is called then I think this should be done.

I think there is none. In general messing with $S is not good idea.
There is a bug related to this
http://bugs.gentoo.org/show_bug.cgi?id=350478 "Allow changing S from
ebuild phases"

I believe that instead of fixing $S better would be rename github's dir
name to proper $S, like I did in fusecompress:

## code
github_user="tex"
github_tag="${PV}"
SRC_URI="https://github.com/${github_user}/${PN}/tarball/${github_tag}
-> ${PN}-git-${PV}.tgz"

src_unpack() {
     unpack ${A}
     mv "${WORKDIR}/${github_user}-${PN}"-??????? "${S}" || die

}

## code

I think this is good time to write about known limitations of localpatch
to wiki.

-- Piotr.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google