Patch for GCC 4.7

[Jerry James]

Hello,

I maintain the fflas-ffpack package for the Fedora Linux distribution.  We had some problems compiling linbox using GCC 4.7, which I traced back to fflas-ffpack.  The attached patch adds an include of <cstring> to fflas-ffpack/fflas/fflas.h, since that file uses memset().  The patch also moves the definition of applyP() before its first use in fflas-ffpack/ffpack/ffpack.h; otherwise, GCC complains about calls to an undeclared function.

Regards,
--
Jerry James

[Brice Boyer]

Hello Jerry.

thank you for your patches. However, which version of fflas-ffpack does this patch to ? The memset issue as well as any gcc-4.7 was corrected in svn but we have made no release since then. Same for linbox. Maybe it is time we should...

thanks,
best.

2012/5/3 Jerry James <logan...@gmail.com>

--
Jerry James

--
You received this message because you are subscribed to the Google Groups "ffpack-devel" group.
To view this discussion on the web visit https://groups.google.com/d/msg/ffpack-devel/-/pVSckRi4pDkJ.
To post to this group, send email to ffpack...@googlegroups.com.
To unsubscribe from this group, send email to ffpack-devel...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/ffpack-devel?hl=en.

--
                                                      Brice Boyer.
____________________________________________________________
brice...@imag.fr                                     Tél. +33(0)4 76 51 45 61
Université Joseph Fourier, Grenoble I.
Laboratoire Jean Kuntzmann, Mathématiques Appliquées et Informatique
LJK - UJF  BP53 38041 Grenoble cedex FRANCE
http://ljk.imag.fr/membres/Brice.Boyer
____________________________________________________________

[Jerry James]

On Friday, May 4, 2012 1:30:29 AM UTC-6, bboyer wrote:

Hello Jerry.

thank you for your patches. However, which version of fflas-ffpack does this patch to ? The memset issue as well as any gcc-4.7 was corrected in svn but we have made no release since then. Same for linbox. Maybe it is time we should...

thanks,
best.

The patch is against the 1.4.3 release, which is what we have in Fedora at the moment.  I prefer to stick with official releases unless there is a compelling reason to do otherwise.  Regards,
--
Jerry James