Possible bug or two

[Chris]

First off, thanks for the script and great work. It suited my needs
and I worked through any difficulties I might have had. Nothing was so
severe I couldn't work around it.

That said, I might have noticed a bug or two when I was working with
Fancybox this week.

var isIE = ($.browser.msie && parseInt($.browser.version.substr(0,1))
< 8);

Doesn't this make the PNG fix function happen on IE 7? I noticed 10
second lock-ups on first load in IE 7 and removed everything on the
page down to Fancybox and it appears this was the culprit for me at
least. I changed the browser version to less than 7 and it seems to
resolve my issues. I'm assuming IE 7 is trying to apply the activeX
alpha filter even though it supports PNGs and is choking.

Additionally I noticed that if your mouse is on an area not covered by
an image after the lightbox comes up and you click very quickly (two-
three-four times in quick succession when not over lightboxed content)
you can get the image stuck in a faded state. This appears to be
catching and calling the jquery fadeOut function repeatedly until you
have a low opacity ghost of the image and can only fix it by
reloading.

I ended up switching all of the fadeOut/fadeIn functions with show and
hide and lost the nice transitions, but users can't double click and
accidentally get stuck with an invisible image. It looked like you had
busy states and cleanup functions to deal with this, but it seems like
they aren't working entirely as intended. I managed to repro this one
on FF and IE.

I also noticed that IE 7 doesn't seem to handle emptying the
fancy_content when it is a flash object too well, so if you close a
lightbox with a Flash movie playing inside of it, the movie continues
to play sound in the background until you open another lightbox. I
didn't have time to resolve this issue.

Thanks for all of your hard work. Really appreciated.

[Janis]

Hi,
Thanks for your effort.
First, you said - "IE 7 is trying to apply the activeX alpha filter
even though it supports PNGs and is choking" - nope, IE7 doesn`t fully
support transparent PNG`s, it has very annoying bug, you can find more
info by googling for "IE7 black shadow png". The only solution I could
find is very simple - applying filters just like for "good, old" IE6.
For opacity ghosting - I think I have fixed that in v1.2.1, I made
some quick tests and could not get FB stuck.
I also just tested youtube clip on IE7 and it stopped correctly, not
sure how you could get situation when FB content is not emptied after
closing.

Janis

[gordon97]

Hi!

First great work, Janis!

>I also noticed that IE 7 doesn't seem to handle emptying the
>fancy_content when it is a flash object too well, so if you close a
>lightbox with a Flash movie playing inside of it, the movie continues
>to play sound in the background until you open another lightbox. I
>didn't have time to resolve this issue.

I can reproduce this behavior testing the inline youtube clip on
examples page.
When you close the FancyBox by clicking on the "X" close button
everything is fine, FancyBox closes correctly and sound stops.
But, when you try closing by clicking outside the FancyBox window,
FancyBox closes, but the sound continues to play in the background.
Using IE 7.0.5730.13 (and also IE6) with Flash WIN 10,0,22,87. Firefox
no problem.

[Chris]

Hey Janis, I see now what you're talking about. I guess because I'd
switched everything to show/hide rather than fading I wasn't seeing
that IE7 black shadow bug. IE 7 only hung on first load or after a
cache clear, but it was 10-15 seconds on many machines I tested on. IE
has so many annoying bugs and them having a half-baked implementation
of PNG support doesn't surprise me.

Maybe fancybox could apply the filter only after the fade ends/begins
to lessen this hang? Is it applying the filter on the initial page
load?

It does appear you've solved the opacity ghosting issue. I can not
reproduce this on the examples page. Awesome!!

What gordon97 described is the same behavior I was seeing as far as
the Flash content was concerned. I apologize for not providing enough
detail on that issue.

> When you close the FancyBox by clicking on the "X" close button
> everything is fine, FancyBox closes correctly and sound stops.
> But, when you try closing by clicking outside the FancyBox window,
> FancyBox closes, but the sound continues to play in the background.

I used an inline media player to play a clip hosted on my site, but it
sounds like the same issue. I can also reproduce this on the examples
page with IE 7.0.6001.18000 and Flash 10,0,2,54.

[Chris]

Something else I probably should have mentioned is the site I was
working on was already running a twin helix png fix before I started
developing this section and I could not easily disable it only for
this section, so this might be duplicated functionality for the pages
I was working on. That could be the reason it hangs for me in IE as
well.

[Janis]

Hi,
Now I got it. I didnt`t put content clearing after closing because I
though - if it's already invisible, so who cares if it is still there.
Unfortunately I didn`t think about flash movies who are still
playing. I`m going to fix this tomorrow. Thanks for noticing this.

IE7 png shadow bug is appearing when png images (in this case - FB
shadows) are animated. To fix this, FB puts filters only once - when
page is loaded, it also checks if there is need to replace background
images with filters. Therefore I don`t think that any other png-fix
plugins could cause problems, but I`ll make some tests to be sure. I`m
not sure why you get such delay, I made test on different computers
and everything seems fine, maybe you could give a link to your page.

Janis

[Chris]

That's great news Janis, thanks for looking into the content clearing.

I can actually reproduce the bug to a somewhat lesser extent on the
examples page (http://fancy.klade.lv/example) in IE 7. It only freezes
for maybe a count of 3 seconds possibly due to it being a fairly
simple page with less images.

If I clear my cache (by going to Tools -> Internet Options -> Delete
all... -> Yes) it will load an image or two then freeze temporarily.
The 3 single images load, the container divs with white backgrounds
show up, and then rather than each image loading progressively one
after another (as a browser usually does) into those containers the
page load hangs 3 seconds then they all pop in at once.

It actually happens less noticeably on every page on the site if you
clear the cache the nav icons, dig link bg, and header image freeze up
for ~3 seconds in IE.

Thanks again for all your help,

Chris