Some suggestions from (prospective) Debian maintainer

[Kartik Mistry]

Hi all,

I successfully built falcon packages of 0.9.6.8 release based on Ubuntu packages plus mongodb changes from git (Error was: http://pastebin.com/kf7ucWY9). Now running Lintian (Debian policy checklist tool) on it, I've some minor issues that can be fix at any later release. These are not urgent at all.

1.  shlib-calls-exit usr/lib/falcon/mongo_fm.so
     shlib-calls-exit usr/lib/libfalcon_engine.so.1.22.2

The listed shared library calls the C library exit() or _exit( functions.

In the case of an error, the library should instead return an appropriate error code to the calling program which can then determine how to handle the error, including performing any required clean-up.

In most cases, removing the call should be discussed with upstream, particularly as it may produce an ABI change.

2. spelling error in manpages:

/usr/share/man/man1/falconeer.fal.1.gz allows to --> should be: allows one to
There are 3 or 4 more such errors.

/usr/share/man/man1/faldisass.1.gz informations --> should be: information

3. spelling error in binary:

/usr/bin/faldisass informations --> should be: information

Thanks,
Kartik

[kunal]

Hi Kartik,

I think the debian package for falcon should not include mongodb module by default. mongodb module can be other package like falcon-mongodb or something in debian.

The falcon package should be only *pure* falcon without any modules( unless there is a dependency ). "ccmake" in your build directory and strip off all the modules and give it a try.

Thanx,

Kunal

[Giancarlo Niccolai]

Il giorno 22/ott/11, alle ore 11:14, kunal ha scritto:

Except for the "feathers". They are considered default.

Gian.

[copyninja]

On Thursday, October 20, 2011 5:43:33 PM UTC+5:30, Kartik Mistry wrote:

2. spelling error in manpages:

/usr/share/man/man1/falconeer.fal.1.gz allows to --> should be: allows one to
There are 3 or 4 more such errors.

/usr/share/man/man1/faldisass.1.gz informations --> should be: information

3. spelling error in binary:

/usr/bin/faldisass informations --> should be: information

Ok I've already patched these spelling mistakes in our package repo. I'm attaching the patches here please review and let me know if it is possible to merge this with upstream repo or if you have some other patch standards

Best Regards
Vasudev

[Steven Oliver]

--
You received this message because you are subscribed to the Google Groups "FalconPL" group.
To view this discussion on the web visit https://groups.google.com/d/msg/falconpl/-/vOOZ_9W981kJ.
To post to this group, send email to falc...@googlegroups.com.
To unsubscribe from this group, send email to falconpl+u...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/falconpl?hl=en.
<01_faldisass_spellfix.patch><02_falpack_spellfix.patch><03_faltest_spellfix.patch><04_fallc_spellfix.patch><05_falconeer_spellfix.patch>

Patches applied. Thank you very much!!

[Giancarlo Niccolai]

Lovely, thanks. I'm patching them right away.

Gian.

[Giancarlo Niccolai]

Uh, didn't read the next mail :-)

Ok, thanks Oliver too!

Gian.

[Vasudev Kamath]

On Sun, Apr 8, 2012 at 5:01 PM, Giancarlo Niccolai <g...@niccolai.cc> wrote:
>
> Uh, didn't read the next mail :-)
>
> Ok, thanks Oliver too!

Thanks Gian and Oliver for excepting the patches :-)

Best Regards

--

Vasudev Kamath
http://copyninja.info
copyninja@{frndk.de|vasudev.homelinux.net}