[Fwd: Re: [Facebooker-talk] Problem on rack_setup]

[Matthew Beale]

Many people are having different problems with Rack.

menno on github:
http://github.com/mmangino/facebooker/commit/308770447db06433e505aaf27db2614cee213cc2#comments

and Carlos Kozuszko on the attached forward.

Can you guys try the attached patch? Instead of the logic tree mess
using insert_after, it tries to use insert_before. It works on my Rails
2.3.2.1 with Rack 1.0 installation.

The feedback will help, thanks all.

--
Matthew Beale :: 607 227 0871
Resume & Portfolio @ http://madhatted.com

[Matthew Beale]

mistyped Menno's email, sorry.

--
Matthew Beale :: 607 227 0871
Resume & Portfolio @ http://madhatted.com

On Mon, 2009-05-25 at 17:12 -0400, Matthew Beale wrote:
> Many people are having different problems with Rack.
>
> menno on github:
> http://github.com/mmangino/facebooker/commit/308770447db06433e505aaf27db2614cee213cc2#comments
>
> and Carlos Kozuszko on the attached forward.
>
> Can you guys try the attached patch? Instead of the logic tree mess
> using insert_after, it tries to use insert_before. It works on my Rails
> 2.3.2.1 with Rack 1.0 installation.
>
> The feedback will help, thanks all.
>

> email message attachment, "Forwarded message - Re: [Facebooker-talk]
> Problem on rack_setup"
> > -------- Forwarded Message --------
> > From: Matthew Beale <mix...@synitech.com>
> > To: Mike Mangino <mman...@elevatedrails.com>
> > Cc: Carlos Kozuszko <car...@insignia4u.com>,
> > faceboo...@rubyforge.org
> > Subject: Re: [Facebooker-talk] Problem on rack_setup
> > Date: Thu, 21 May 2009 11:58:51 -0400
> >
> > How about:
> >
> > ActionController::Dispatcher.middleware.insert_before(
> > ActionController::ParamsParser,
> > Rack::Facebook,
> > Facebooker.secret_key )
> >
> > Insert before? I think all three of the situations we're coding for
> > happen right before params parser.
> >
> > Middleware on my rails 2.3 has the same flow before an after the
> > attached patch. Can you guys check it and if we're good it can be
> > merged?
> >
> > You can `rake middleware` for a quick check.
> >
> > _______________________________________________
> > Facebooker-talk mailing list
> > Faceboo...@rubyforge.org
> > http://rubyforge.org/mailman/listinfo/facebooker-talk

[Menno van der Sman]

Hi Matthew,

Thanks for the follow up. The patch you proposed works fine here as
well. (rails 2.3.2.1 with bundled rack).

Cheers,

Menno

On May 25, 11:16 pm, Matthew Beale <mixo...@synitech.com> wrote:
> mistyped Menno's email, sorry.
>
> --
> Matthew Beale :: 607 227 0871

> Resume & Portfolio @http://madhatted.com

>
>
>
> On Mon, 2009-05-25 at 17:12 -0400, Matthew Beale wrote:
> > Many people are having different problems with Rack.
>
> > menno on github:

> >http://github.com/mmangino/facebooker/commit/308770447db06433e505aaf2...

> > > Facebooker-t...@rubyforge.org
> > >http://rubyforge.org/mailman/listinfo/facebooker-talk

[Mike Mangino]

I just committed this patch. Let me know if it causes problems for anybody.

Mike

From: Matthew Beale <mix...@synitech.com>

Date: May 21, 2009 11:58:51 AM EDT

To: Mike Mangino <mman...@elevatedrails.com>

Cc: Carlos Kozuszko <car...@insignia4u.com>, faceboo...@rubyforge.org

Subject: Re: [Facebooker-talk] Problem on rack_setup

How about:

ActionController::Dispatcher.middleware.insert_before(
 ActionController::ParamsParser,
 Rack::Facebook,
 Facebooker.secret_key )

Insert before?  I think all three of the situations we're coding for
happen right before params parser.

Middleware on my rails 2.3 has the same flow before an after the
attached patch.  Can you guys check it and if we're good it can be
merged?

You can `rake middleware` for a quick check.

--
Matthew Beale :: 607 227 0871
Resume & Portfolio @ http://madhatted.com

On Thu, 2009-05-21 at 08:19 -0400, Mike Mangino wrote:

That sounds sane to me.

Mike

On May 20, 2009, at 2:53 PM, Carlos Kozuszko wrote:

I'm having problems trying to set up facebooker on a Rails 2.3.2

project using :active_record_store for cookies. The problem happens

because of this commit:

http://github.com/mmangino/facebooker/commit/308770447db06433e505aaf27db2614cee213cc2

That code is trying to add the Rack::Facebook to the dispatch chain

after ActionController::RewindableInput or

ActionController::Session::CookieStore if the first one is not found.

The problem in my case is that I'm not using cookies, so this sould

fall back to ActiveRecord::SessionStore.

I could provide a patch, but wanted to be sure if what I'm saying is  

correct.

Thanks!

Carlos K.

--

http://www.ckozus.com

http://www.insignia4u.com

_______________________________________________

Facebooker-talk mailing list

Faceboo...@rubyforge.org

http://rubyforge.org/mailman/listinfo/facebooker-talk

--

Mike Mangino

http://www.elevatedrails.com

_______________________________________________

Facebooker-talk mailing list

Faceboo...@rubyforge.org

http://rubyforge.org/mailman/listinfo/facebooker-talk

<move_rack_before_params_parser_instead_of_after_with_logic.patch>_______________________________________________

Facebooker-talk mailing list
Faceboo...@rubyforge.org
http://rubyforge.org/mailman/listinfo/facebooker-talk

<move_rack_before_params_parser_instead_of_after_with_logic.patch>

--

Mike Mangino

http://www.elevatedrails.com