Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

De-static functions' prototypes

0 views
Skip to first unread message

Alexey E. Suslikov

unread,
May 21, 2013, 1:41:45 PM5/21/13
to te...@openbsd.org
> CVSROOT: /cvs
> Module name: src
> Changes by: kettenis <at> cvs.openbsd.org 2013/05/20 11:34:08
>
> Modified files:
> sys/arch/i386/i386: amd64errata.c
> sys/arch/amd64/amd64: amd64errata.c
>
> Log message:
> de-static-ize, such that people don't get confused by aesni failures on
> AMD hardware the next time somebody tries to run on a broken KVM hypervisor.

unfortunately, it still confuses with aesni failures.

de-static-izing functions' prototypes makes things look
as expected.

Index: arch/amd64/amd64/amd64errata.c
===================================================================
RCS file: /cvs/src/sys/arch/amd64/amd64/amd64errata.c,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 amd64errata.c
--- arch/amd64/amd64/amd64errata.c 20 May 2013 17:34:08 -0000 1.4
+++ arch/amd64/amd64/amd64errata.c 20 May 2013 20:17:00 -0000
@@ -129,8 +129,8 @@ static const uint8_t amd64_errata_set9[]
DA_C3, HY_D0, HY_D1, HY_D1_G34R1, PH_E0, LN_B0, OINK
};

-static int amd64_errata_setmsr(struct cpu_info *, errata_t *);
-static int amd64_errata_testmsr(struct cpu_info *, errata_t *);
+int amd64_errata_setmsr(struct cpu_info *, errata_t *);
+int amd64_errata_testmsr(struct cpu_info *, errata_t *);

static errata_t errata[] = {
/*
Index: arch/i386/i386/amd64errata.c
===================================================================
RCS file: /cvs/src/sys/arch/i386/i386/amd64errata.c,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 amd64errata.c
--- arch/i386/i386/amd64errata.c 20 May 2013 17:34:08 -0000 1.4
+++ arch/i386/i386/amd64errata.c 20 May 2013 20:17:01 -0000
@@ -129,8 +129,8 @@ static const uint8_t amd64_errata_set9[]
DA_C3, HY_D0, HY_D1, HY_D1_G34R1, PH_E0, LN_B0, OINK
};

-static int amd64_errata_setmsr(struct cpu_info *, errata_t *);
-static int amd64_errata_testmsr(struct cpu_info *, errata_t *);
+int amd64_errata_setmsr(struct cpu_info *, errata_t *);
+int amd64_errata_testmsr(struct cpu_info *, errata_t *);

static errata_t errata[] = {
/*


Mark Kettenis

unread,
May 21, 2013, 5:13:23 PM5/21/13
to alexey....@gmail.com, te...@openbsd.org
> From: "Alexey E. Suslikov" <alexey....@gmail.com>
> Date: Tue, 21 May 2013 17:40:43 +0000 (UTC)
>
> > CVSROOT: /cvs
> > Module name: src
> > Changes by: kettenis <at> cvs.openbsd.org 2013/05/20 11:34:08
> >
> > Modified files:
> > sys/arch/i386/i386: amd64errata.c
> > sys/arch/amd64/amd64: amd64errata.c
> >
> > Log message:
> > de-static-ize, such that people don't get confused by aesni failures on
> > AMD hardware the next time somebody tries to run on a broken KVM hypervisor.
>
> unfortunately, it still confuses with aesni failures.
>
> de-static-izing functions' prototypes makes things look
> as expected.

Thanks. Committed now.
0 new messages