Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] scsi/mpt2sas: remove unnecesscary preempt requirement for MSIX

12 views
Skip to first unread message

Alex Shi

unread,
Apr 28, 2012, 2:28:50 AM4/28/12
to JBott...@parallels.com, Nagalakshm...@lsi.com, linux...@vger.kernel.org, linux-...@vger.kernel.org, alex...@intel.com
smp_processor_id() need used in preempt safe ENV. Otherwise, the
cpu may be preempted and run on other cpus. But here, we don't care much
the specific CPU which handler the MSI, so just replace it by
raw_smp_processor_id() to avoid preempt debug warning.

Signed-off-by: Alex Shi <alex...@intel.com>
---
drivers/scsi/mpt2sas/mpt2sas_base.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
index 8a59a77..3f518ba 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -1785,7 +1785,7 @@ static inline void _base_writeq(__u64 b, volatile void __iomem *addr,
static inline u8
_base_get_msix_index(struct MPT2SAS_ADAPTER *ioc)
{
- return ioc->cpu_msix_table[smp_processor_id()];
+ return ioc->cpu_msix_table[raw_smp_processor_id()];
}

/**
--
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Nandigama, Nagalakshmi

unread,
Apr 30, 2012, 1:29:37 AM4/30/12
to Alex Shi, JBott...@parallels.com, linux...@vger.kernel.org, linux-...@vger.kernel.org
Alex,
I submitted this patch already.

James, request you to pick up the patch that I previously submitted for fixing this issue. Attaching the patch that I submitted previously.


Regards,
Nagalakshmi

Alex Shi

unread,
Apr 30, 2012, 11:36:40 PM4/30/12
to Nandigama, Nagalakshmi, JBott...@parallels.com, linux...@vger.kernel.org, linux-...@vger.kernel.org
On 04/30/2012 01:29 PM, Nandigama, Nagalakshmi wrote:

> Alex,
> I submitted this patch already.


Ok. that's fine.
0 new messages