Received: by 10.68.232.169 with SMTP id tp9mr337830pbc.6.1333143184928;
        Fri, 30 Mar 2012 14:33:04 -0700 (PDT)
Path: z9ni20025pbe.0!nntp.google.com!news2.google.com!goblin2!goblin1!goblin.stu.neva.ru!uio.no!nntp.uio.no!.POSTED!not-for-mail
From: Greg KH <gre...@linuxfoundation.org>
Newsgroups: fa.linux.kernel
Subject: Re: [PATCH] kmsg: Use vmalloc instead of kmalloc when writing
Date: Fri, 30 Mar 2012 21:33:04 UTC
Organization: Internet mailing list
Lines: 24
Sender: linux-kernel-ow...@vger.kernel.org
Message-ID: <fa.Yk0rbPDC+u1VoJmuX71dpVKnN+k@ifi.uio.no>
References: <fa.hJnaaBKxZCTbfJLEqDxoEk0ABGU@ifi.uio.no> <fa.Rrltlq7T2tWV7ZLzGntBFKAS2o4@ifi.uio.no> <fa.nRK1qYc4NiTEjZ1k4nfbWj6ZWrU@ifi.uio.no> <fa.9DJX/ZKA/37SGWxyPbHL+v7xCTY@ifi.uio.no>
NNTP-Posting-Host: mail-jess.uio.no
Mime-Version: 1.0
X-Trace: readme.uio.no 1333143184 10437 129.240.7.9 (30 Mar 2012 21:33:04 GMT)
X-Complaints-To: abuse@uio.no
NNTP-Posting-Date: Fri, 30 Mar 2012 21:33:04 +0000 (UTC)
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Thomas Gleixner <t...@linutronix.de>,
	Sasha Levin <levinsasha...@gmail.com>, v...@zeniv.linux.org.uk,
	da...@redhat.com, linux-ker...@vger.kernel.org
To: Arnd Bergmann <a...@arndb.de>
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
	messagingengine.com; h=date:from:to:cc:subject:message-id
	:references:mime-version:content-type:in-reply-to; s=smtpout;
	 bh=PgfSylNBu2twHcL65FUvEalOihs=; b=jqxi1paMcDbxJz+hr0thUtiedESP
	bW0n1rCQmBGXPBOGnzJm4oRElB8z4v+ycNqOGbxTkxaxYsjID+qerbueXjCNhPjE
	akG4/NiC8lJs/XYfAyXqUTNF6BkGgKxZ2UAYTkC3gv4pFLYj4aHwxlJOV5UwsmcT
	+5qlVXCziklQX2E=
X-Sasl-enc: hQvA0F01SI9h4iGO9X9uKQ2DmgZQaPOZ+EesR3Cyekrs 1333143174
In-Reply-To: <201203302105.52987.arnd@arndb.de>
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Original-Date: Fri, 30 Mar 2012 14:17:44 -0700
Original-Message-Id: <20120330211744.GA16314@kroah.com>
Original-References: <1333127067-2043-1-git-send-email-levinsasha...@gmail.com>
 <20120330204235.GA...@kroah.com>
 <alpine.LFD.2.02.1203302247130.2542@ionos>
 <201203302105.52987.a...@arndb.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Mar 30, 2012 at 09:05:52PM +0000, Arnd Bergmann wrote:
> On Friday 30 March 2012, Thomas Gleixner wrote:
> > I think so. This is an interface to inject stuff into dmesg. Limiting
> > that to a reasonable size makes sense. We can probably limit it to
> > something small like 1024, but I don't know about the "ideas" of those
> > folks who think that it's a great idea to do it at all.
> 
> I guess a page would be a reasonable size, similar to what we do for
> sysfs. 

Ok. Sasha, as you seem to have noticed this, care to dig in syslog and
systemd to get an idea of the buffer sizes they are expecting to pass
into kmsg, and if they can handle a short write properly?  If so,
restricting it to a page is fine with me, otherwise we might want to
make it a bit bigger.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/