Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] sysfs: fix SYSFS_DEPRECATED_V2 prompt

11 views
Skip to first unread message

Randy Dunlap

unread,
Nov 23, 2009, 6:58:04 PM11/23/09
to LKML, Greg KH, kay.s...@vrfy.org, Andrew Morton
From: Randy Dunlap <randy....@oracle.com>

The SYSFS_DEPRECATED_V2 says "remove" older, deprecated features,
but it actually enables them, so correct this confusing, backwards
text.

Signed-off-by: Randy Dunlap <randy....@oracle.com>
Cc: Kay Sievers <kay.s...@vrfy.org>
---
init/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-2632-rc8.orig/init/Kconfig
+++ lnx-2632-rc8/init/Kconfig
@@ -606,7 +606,7 @@ config SYSFS_DEPRECATED
bool

config SYSFS_DEPRECATED_V2
- bool "remove sysfs features which may confuse old userspace tools"
+ bool "enable deprecated sysfs features which may confuse old userspace tools"
depends on SYSFS
default n
select SYSFS_DEPRECATED
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Randy Dunlap

unread,
Dec 3, 2009, 11:32:39 AM12/3/09
to Uwe Kleine-König, LKML, Greg KH, kay.s...@vrfy.org, Andrew Morton, Linus Torvalds
On Thu, 3 Dec 2009 09:03:41 +0100 Uwe Kleine-K�nig wrote:

> Hello,


>
> > config SYSFS_DEPRECATED_V2
> > - bool "remove sysfs features which may confuse old userspace tools"
> > + bool "enable deprecated sysfs features which may confuse old userspace tools"

> Is this better? SYSFS_DEPRECATED_V2 enables deprecated sysfs features,
> but this is done to *not* confuse old userspace tools, isn't it?


Hm, agreed that it is still a bit ambiguous.
Feel free to send (another) patch.

thanks,
---
~Randy

Uwe Kleine-König

unread,
Dec 3, 2009, 1:58:19 PM12/3/09
to linux-...@vger.kernel.org, tri...@kernel.org, Greg KH, Andrew Morton, Kay Sievers, Randy Dunlap, Linus Torvalds
Signed-off-by: Uwe Kleine-König <u.klein...@pengutronix.de>
Cc: Greg KH <gre...@suse.de>
Cc: Andrew Morton <ak...@linux-foundation.org>
Cc: Kay Sievers <kay.s...@vrfy.org>
Cc: Randy Dunlap <randy....@oracle.com>
Cc: Linus Torvalds <torv...@linux-foundation.org>
---
init/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/init/Kconfig b/init/Kconfig
index eb4b337..d7ac66b 100644
--- a/init/Kconfig
+++ b/init/Kconfig


@@ -606,7 +606,7 @@ config SYSFS_DEPRECATED
bool

config SYSFS_DEPRECATED_V2

- bool "enable deprecated sysfs features which may confuse old userspace tools"
+ bool "enable deprecated sysfs features to support old userspace tools"


depends on SYSFS
default n
select SYSFS_DEPRECATED
--

1.6.5.2

Randy Dunlap

unread,
Dec 3, 2009, 2:33:00 PM12/3/09
to Uwe Kleine-König, linux-...@vger.kernel.org, tri...@kernel.org, Greg KH, Andrew Morton, Kay Sievers, Linus Torvalds
On Thu, 3 Dec 2009 19:58:00 +0100 Uwe Kleine-K�nig wrote:

> Signed-off-by: Uwe Kleine-K�nig <u.klein...@pengutronix.de>


> Cc: Greg KH <gre...@suse.de>
> Cc: Andrew Morton <ak...@linux-foundation.org>
> Cc: Kay Sievers <kay.s...@vrfy.org>
> Cc: Randy Dunlap <randy....@oracle.com>
> Cc: Linus Torvalds <torv...@linux-foundation.org>

Acked-by: Randy Dunlap <randy....@oracle.com>

Thanks.


> ---
> init/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index eb4b337..d7ac66b 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -606,7 +606,7 @@ config SYSFS_DEPRECATED
> bool
>
> config SYSFS_DEPRECATED_V2
> - bool "enable deprecated sysfs features which may confuse old userspace tools"
> + bool "enable deprecated sysfs features to support old userspace tools"
> depends on SYSFS
> default n
> select SYSFS_DEPRECATED
> --


---
~Randy

0 new messages