Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Re: [2.6 patch] dpt_i2o fix for deadlock condition

0 views
Skip to first unread message

Lennart Sorensen

unread,
Nov 29, 2005, 1:05:11 PM11/29/05
to Salyzyn, Mark, linux...@vger.kernel.org, James.B...@steeleye.com, linux-...@vger.kernel.org
On Tue, Nov 29, 2005 at 11:51:25AM -0500, Salyzyn, Mark wrote:
> Miquel van Smoorenburg <miq...@cistron.nl> forwarded me this fix to
> resolve a deadlock condition that occurs due to the API change in
> 2.6.13+ kernels dropping the host locking when entering the error
> handling. They all end up calling adpt_i2o_post_wait(), which if you
> call it unlocked, might return with host_lock locked anyway and that
> causes a deadlock.
>
> Signed-off-by: Mark Salyzyn <aac...@adaptec.com>
>
> drivers/scsi/dpt_i2o.c | 25 ++++++++++++++++++++-----
> 1 file changed, 20 insertions(+), 5 deletions(-)
>
> Patch attached to email due to Outlook corrupting content when inlined.

There must still be a way to tell outlook to make the type something
useful, rather than application/octet-stream. maybe if the extension
was .patch.txt it would do something smarter.

Len Sorensen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Adrian Bunk

unread,
Nov 29, 2005, 1:54:02 PM11/29/05
to Lennart Sorensen, Salyzyn, Mark, linux...@vger.kernel.org, James.B...@steeleye.com, linux-...@vger.kernel.org
On Tue, Nov 29, 2005 at 01:04:37PM -0500, Lennart Sorensen wrote:
> On Tue, Nov 29, 2005 at 11:51:25AM -0500, Salyzyn, Mark wrote:
> > Miquel van Smoorenburg <miq...@cistron.nl> forwarded me this fix to
> > resolve a deadlock condition that occurs due to the API change in
> > 2.6.13+ kernels dropping the host locking when entering the error
> > handling. They all end up calling adpt_i2o_post_wait(), which if you
> > call it unlocked, might return with host_lock locked anyway and that
> > causes a deadlock.
> >
> > Signed-off-by: Mark Salyzyn <aac...@adaptec.com>
> >
> > drivers/scsi/dpt_i2o.c | 25 ++++++++++++++++++++-----
> > 1 file changed, 20 insertions(+), 5 deletions(-)
> >
> > Patch attached to email due to Outlook corrupting content when inlined.
>
> There must still be a way to tell outlook to make the type something
> useful, rather than application/octet-stream. maybe if the extension
> was .patch.txt it would do something smarter.

Patches in Attachments aren't nice, but better than corrupted patches.

It's unfortunate, but bitching on the people who are somehow forced to
use crappy email clients is IMHO not a good idea.

> Len Sorensen

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

0 new messages