Attached is a simple charactor driver for possible inclusion in your MM tree.
This driver is specific to the MPCBL0010 that will start shipping this fall.
The telcom clock is a special circuit, line card PLL, that provids a mechanism for synchronization of specialized hardware across the backplane of a chassis of multiple computers with similar specail curcits. In this case the synchronization signals get routed to multiple places, typically to pins on expansion slots for hardware that knows what to do with this signal. (SONET, G.813, stratum 3...) and similar signaling applications found in telcom sites can use this type of thing.
The actual device is hidden behind the FPGA on the motherboar, and is connected to the FPGA via I2C. This driver only talks to the FPGA registers.
Thanks,
-- --mgross BTW: This may or may not be the opinion of my employer, more likely not.
> Attached is a simple charactor driver for possible inclusion in your MM tree.
> This driver is specific to the MPCBL0010 that will start shipping this fall.
> The telcom clock is a special circuit, line card PLL, that provids a mechanism > for synchronization of specialized hardware across the backplane of a chassis > of multiple computers with similar specail curcits. In this case the > synchronization signals get routed to multiple places, typically to pins on > expansion slots for hardware that knows what to do with this signal. (SONET, > G.813, stratum 3...) and similar signaling applications found in telcom sites > can use this type of thing.
> The actual device is hidden behind the FPGA on the motherboar, and is > connected to the FPGA via I2C. This driver only talks to the FPGA registers.
A few minor style and spelling comments :
[snip]
> + * > + * Send feedback to <sebastien.bouch...@ca.kontron.com> > + * > + * 2.6 driver version being maintained by <mark.gr...@intel.com>
shouldn't this info go into CREDITS/MAINTAINERS and the above then simply be
* Send feedback to Sebastien Bouchard and the current maintainer.
???
Same comment for the other files.
[snip]
> +/* sysFS interface definition:
Isn't it just called "sysfs" without the caps?
> +Uppon loading the driver will create a sysfs directory under class/misc/tlclk.
s/Uppon/Upon/
> + > +This directory exports the following interfaces. There opperation is documented
Line exceeds 80 characters (in this case due to trailing whitespace).
Let me quote Documentation/CodingStyle Chapter 2 :
" The limit on the length of lines is 80 columns and this is a hard limit.
Statements longer than 80 columns will be broken into sensible chunks. Descendants are always substantially shorter than the parent and are placed substantially to the right. The same applies to function headers with a long argument list. Long strings are as well broken into shorter strings. "
You have both comment and code lines elsewhere in the file that exceed this. Please fix.
And while you are at it, please get rid of all the trailing whitespace. A simple sed script will do it like this :
sed -r s/"[ \t]+$"/""/ file_with_trailing_whitespace.c > fixed_file.c
[snip]
> +All sysfs interaces are integers in hex format, i.e echo 99 > refalign
> On 10/6/05, Mark Gross <mgr...@linux.intel.com> wrote:
> > Andrew,
> > Attached is a simple charactor driver for possible inclusion in your MM tree.
> > This driver is specific to the MPCBL0010 that will start shipping this fall.
> > The telcom clock is a special circuit, line card PLL, that provids a mechanism > > for synchronization of specialized hardware across the backplane of a chassis > > of multiple computers with similar specail curcits. In this case the > > synchronization signals get routed to multiple places, typically to pins on > > expansion slots for hardware that knows what to do with this signal. (SONET, > > G.813, stratum 3...) and similar signaling applications found in telcom sites > > can use this type of thing.
> > The actual device is hidden behind the FPGA on the motherboar, and is > > connected to the FPGA via I2C. This driver only talks to the FPGA registers.
> A few minor style and spelling comments :
> [snip] > > + * > > + * Send feedback to <sebastien.bouch...@ca.kontron.com> > > + * > > + * 2.6 driver version being maintained by <mark.gr...@intel.com>
> shouldn't this info go into CREDITS/MAINTAINERS and the above then simply be
> * Send feedback to Sebastien Bouchard and the current maintainer.
> ???
> Same comment for the other files.
> [snip] > > +/* sysFS interface definition:
> Isn't it just called "sysfs" without the caps?
> > +Uppon loading the driver will create a sysfs directory under class/misc/tlclk.
> s/Uppon/Upon/
> > + > > +This directory exports the following interfaces. There opperation is documented
> Line exceeds 80 characters (in this case due to trailing whitespace).
> Let me quote Documentation/CodingStyle Chapter 2 :
> " > The limit on the length of lines is 80 columns and this is a hard limit.
> Statements longer than 80 columns will be broken into sensible chunks. > Descendants are always substantially shorter than the parent and are placed > substantially to the right. The same applies to function headers with a long > argument list. Long strings are as well broken into shorter strings. > "
> You have both comment and code lines elsewhere in the file that exceed this. > Please fix.
> And while you are at it, please get rid of all the trailing whitespace. A > simple sed script will do it like this :
> sed -r s/"[ \t]+$"/""/ file_with_trailing_whitespace.c > fixed_file.c
> [snip] > > +All sysfs interaces are integers in hex format, i.e echo 99 > refalign
> Most of your functions nicely place the '*' next to the variable name, but this > one, the next one and a few other cases do not. Please be consistent.
> Can you drop ioctl part of interface and leave only sysfs one?
I would like to keep if for a little while because the hardware validation guys are still using test harnesses written for the 2.4 kernel driver version. However; I am willing to pull this block if that would help in getting this driver into the kernel.
-- --mgross BTW: This may or may not be the opinion of my employer, more likely not. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Try registering a whole attribute group instead. It's much nicer than the 20 lines you have to register and unregister your devices (and you don't handle the error condition properly if something goes wrong half way through.)
> Try registering a whole attribute group instead. It's much nicer than > the 20 lines you have to register and unregister your devices (and you > don't handle the error condition properly if something goes wrong half > way through.)
I couldn't find such an API that wasn't static to class.c, or described in class.txt. Any pointers on this would be helpful.
