Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
fa.linux.kernel
+ new post
About this group
Subscribe to this group
This is a Usenet group - learn more
[SCSI] virtio-scsi: Initialize scatterlist structure.
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   5 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Richard W.M. Jones  
View profile  
 More options Aug 20 2012, 10:05 am
Newsgroups: fa.linux.kernel
From: "Richard W.M. Jones" <rjo...@redhat.com>
Date: Mon, 20 Aug 2012 14:05:24 UTC
Local: Mon, Aug 20 2012 10:05 am
Subject: [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.
Print | Individual message | Show original | Report this message | Find messages by this author
From: "Richard W.M. Jones" <rjo...@redhat.com>

The sg struct is used without being initialized.

https://bugzilla.redhat.com/show_bug.cgi?id=847548

Signed-off-by: Richard W.M. Jones <rjo...@redhat.com>
---
 drivers/scsi/virtio_scsi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index c7030fb..8a66f83 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi,
        struct scatterlist sg;
        unsigned long flags;

-       sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
+       sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event));

        spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags);

--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Paolo Bonzini  
View profile  
 More options Aug 20 2012, 10:05 am
Newsgroups: fa.linux.kernel
From: Paolo Bonzini <pbonz...@redhat.com>
Date: Mon, 20 Aug 2012 14:05:53 UTC
Local: Mon, Aug 20 2012 10:05 am
Subject: Re: [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.
Print | Individual message | Show original | Report this message | Find messages by this author
Il 20/08/2012 16:04, Richard W.M. Jones ha scritto:

Acked-by: Paolo Bonzini <pbonz...@redhat.com>

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Paolo Bonzini  
View profile  
 More options Oct 1 2012, 9:13 am
Newsgroups: fa.linux.kernel
From: Paolo Bonzini <pbonz...@redhat.com>
Date: Mon, 01 Oct 2012 13:13:16 UTC
Local: Mon, Oct 1 2012 9:13 am
Subject: Re: [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.
Print | Individual message | Show original | Report this message | Find messages by this author
Il 20/08/2012 16:05, Paolo Bonzini ha scritto:

Ping, is this patch going into 3.7?

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Richard W.M. Jones  
View profile  
 More options Oct 1 2012, 9:19 am
Newsgroups: fa.linux.kernel
From: "Richard W.M. Jones" <rjo...@redhat.com>
Date: Mon, 01 Oct 2012 13:19:12 UTC
Local: Mon, Oct 1 2012 9:19 am
Subject: Re: [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.
Print | Individual message | Show original | Report this message | Find messages by this author

I was a bit surprised to see this wasn't upstream since it's vital for
using virtio-scsi reliably (as well as being a one line fix for a
blatant bug).

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Paolo Bonzini  
View profile  
 More options Oct 1 2012, 9:21 am
Newsgroups: fa.linux.kernel
From: Paolo Bonzini <pbonz...@redhat.com>
Date: Mon, 01 Oct 2012 13:21:15 UTC
Local: Mon, Oct 1 2012 9:21 am
Subject: Re: [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.
Print | Individual message | Show original | Report this message | Find messages by this author
Il 01/10/2012 15:18, Richard W.M. Jones ha scritto:

Indeed I enclosed it in a submission named "[PATCH for 3.6] urgent
virtio-scsi fixes"
(http://permalink.gmane.org/gmane.linux.kernel/1350337)...

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google