[PATCH] Only ongrab kuake hotkey if the $term is not embedded.

[Mark Pustjens]

Hi List,

This patch prevents the kuake hotkey from not working anymore when an
embedded instance of urxvt is closed.
---
src/perl/kuake | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/perl/kuake b/src/perl/kuake
index e6c5949..3551df3 100644
--- a/src/perl/kuake
+++ b/src/perl/kuake
@@ -45,8 +45,9 @@ sub on_root_event {
sub on_destroy {
my ($self) = @_;

- $self->XUngrabKey ($self->XKeysymToKeycode ($self->{keysym}), 0,
$self->DefaultRootWindow)
- if $self->{keysym};
+ if (!${self}->resource("embed") && $self->{keysym}) {
+ $self->XUngrabKey ($self->XKeysymToKeycode ($self->{keysym}), 0,
$self->DefaultRootWindow);
+ }

()
}

--
There are hardly any excesses of the most crazed psychopath that
cannot easily be duplicated by a normal kindly family man who just
comes in to work every day and has a job to do.
(Small Gods)

[Aren Olson]

Hi Mark,

This isn't the kuake development list, so there's not really anything we can do with that patch. :)

Wikipedia says that kuake is not under development, and has been succeeded by yakuake. You should probably direct your patch their way, assuming this is still an issue in yakuake.

HTH

-Aren

--
You received this message because you are subscribed to the Google Groups "exaile-devel" group.
To post to this group, send email to exaile...@googlegroups.com.
To unsubscribe from this group, send email to exaile-devel+unsubscribe@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/exaile-devel?hl=en.

[Mark Pustjens]

On Wed, 7 Dec 2011, Aren Olson wrote:

> Hi Mark,
> This isn't the kuake development list, so there's not really anything we can do with that patch. :)

Whoops. Copy&paste error with the address :)

>
> Wikipedia says that kuake is not under development, and has been succeeded by yakuake. You should probably direct your patch their way, assuming this is still an issue in yakuake.

This is for urxvt's kuake perl extensions, it still is an issue.

Sorry for messing up.

> To unsubscribe from this group, send email to exaile-devel...@googlegroups.com.

> For more options, visit this group at http://groups.google.com/group/exaile-devel?hl=en.
>
>

> --
> You received this message because you are subscribed to the Google Groups "exaile-devel" group.
> To post to this group, send email to exaile...@googlegroups.com.

> To unsubscribe from this group, send email to exaile-devel...@googlegroups.com.

> For more options, visit this group at http://groups.google.com/group/exaile-devel?hl=en.
>
>

Greetings/Groetjes

Mark Pustjens

--
"He's muffed it," said Simony. "he could have done *anything* with
them. And he just told them the facts. You can't inspire people with
facts. They need a cause. They need a symbol."
(Small Gods)