Message from discussion
gproc patch
Received: by 10.14.119.129 with SMTP id n1mr397864eeh.1.1295545405835;
Thu, 20 Jan 2011 09:43:25 -0800 (PST)
X-BeenThere: erlang-programming@googlegroups.com
Received: by 10.14.26.28 with SMTP id b28ls72016eea.5.p; Thu, 20 Jan 2011
09:43:25 -0800 (PST)
Received: by 10.14.127.6 with SMTP id c6mr402703eei.19.1295545404933;
Thu, 20 Jan 2011 09:43:24 -0800 (PST)
Received: by 10.14.127.6 with SMTP id c6mr402702eei.19.1295545404883;
Thu, 20 Jan 2011 09:43:24 -0800 (PST)
Return-Path: <erlang-questions-return-55912-erlang-programming+garchive-81772=googlegroups....@erlang.org>
Received: from morgoth.cslab.ericsson.net (morgoth.cslab.ericsson.net [193.180.168.22])
by gmr-mx.google.com with SMTP id 41si2675973ees.1.2011.01.20.09.43.24;
Thu, 20 Jan 2011 09:43:24 -0800 (PST)
Received-SPF: pass (google.com: domain of erlang-questions-return-55912-erlang-programming+garchive-81772=googlegroups....@erlang.org designates 193.180.168.22 as permitted sender) client-ip=193.180.168.22;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of erlang-questions-return-55912-erlang-programming+garchive-81772=googlegroups....@erlang.org designates 193.180.168.22 as permitted sender) smtp.mail=erlang-questions-return-55912-erlang-programming+garchive-81772=googlegroups....@erlang.org; dkim=neutral (body hash did not verify) header...@gmail.com
Received: (qmail 6684 invoked by alias); 20 Jan 2011 17:42:57 -0000
Mailing-List: contact erlang-questions-h...@erlang.org; run by ezmlm
Sender: <erlang-questi...@erlang.org>
Precedence: bulk
List-Id: Erlang/OTP discussions <erlang-questions.erlang.org>
List-Post: <mailto:erlang-questi...@erlang.org>
List-Help: <mailto:erlang-questions-h...@erlang.org>
List-Unsubscribe: <mailto:erlang-questions-unsubscr...@erlang.org>
List-Subscribe: <mailto:erlang-questions-subscr...@erlang.org>
List-Archive: <http://www.erlang.org/cgi-bin/ezmlm-cgi/4>
Delivered-To: mailing list erlang-questi...@erlang.org
Received: (qmail 22005 invoked from network); 20 Jan 2011 17:42:56 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=gamma;
h=domainkey-signature:mime-version:in-reply-to:references:date
:message-id:subject:from:to:cc:content-type
:content-transfer-encoding;
bh=8GpU5U6TLYuYDmRiPMBvumbsHhitmKFFejVSvMrc0Pc=;
b=X7it2BwKQG2pVkB6FmNMR9Y6ANfB71z6jQ2CSh8YfUNAse8tW/x4sIGgQqigY6HkEo
f1DkufAjvSMF28uNGeUt986rfgC7MmhWcYeosHbmYPWrss5M3BdsmjYk3bKWwE1ZzxB1
f52JkN0SoTPd/3s4U1istBceXEAxH0EoJXPvc=
DomainKey-Signature: a=rsa-sha1; c=nofws;
d=gmail.com; s=gamma;
h=mime-version:in-reply-to:references:date:message-id:subject:from:to
:cc:content-type:content-transfer-encoding;
b=C9/5V8fM6BnPmLqFqU+VbrW3wR3i35f4I+YjY1AJyceGaoDpWrSw15o/i4ZWlAQpXg
BF+f0VmMVr2IVR/euVHSPtTzv4SVV5c/XKf3VAx7vPA0YIxTpAoKfsaBfKQDwdk5QW3B
3/0G6xdbqdMzwRtV1bPT+OXNLrpdb8mDAxaHc=
MIME-Version: 1.0
In-Reply-To: <D60B5013-C4F0-4FF4-86F4-38E93FCA5...@erlang-solutions.com>
References: <AANLkTinghEfKEQvGYqMdDYch3TC8DHd=26XG+fVMh...@mail.gmail.com>
<D60B5013-C4F0-4FF4-86F4-38E93FCA5...@erlang-solutions.com>
Date: Thu, 20 Jan 2011 09:42:55 -0800
Message-ID: <AANLkTimFek3THsv5m9NN0cYZA22i-pk35v13s4GM2...@mail.gmail.com>
From: Garret Smith <garret.sm...@gmail.com>
To: Ulf Wiger <ulf.wi...@erlang-solutions.com>
Cc: erlang-questi...@erlang.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [erlang-questions] gproc patch
I was using the version at https://github.com/uwiger/gproc.git which
looks identical except for that patch :)
-G
On Thu, Jan 20, 2011 at 9:02 AM, Ulf Wiger
<ulf.wi...@erlang-solutions.com> wrote:
>
> Hi Garrett,
>
> Which version of gproc are you using?
>
> That particular bug was fixed on Jan 11 in http://github.com/esl/gproc
> (That is, quite recently. :)
>
> Sending pull requests to that project will work just fine.
>
> BR,
> Ulf W
>
> On 19 Jan 2011, at 01:21, Garret Smith wrote:
>
>> Fixed a small issue with gproc in the 'await' function when no timeout
>> is specified.
>>
>> see branch 'fix-await-notimeout' in the repository
>> git://github.com/garret-smith/gproc.git
>>
>> or the patch:
>>
>> --- a/src/gproc.erl
>> +++ b/src/gproc.erl
>> @@ -312,7 +312,7 @@ request_wait({n,C,_} =3D Key, Timeout) when C=3D=3Dl=
; C=3D=3Dg ->
>> =A0 =A0 WRef =3D call({await,Key,self()}, C),
>> =A0 =A0 receive
>> =A0 =A0 =A0 =A0 {gproc, WRef, registered, {_K, Pid, V}} ->
>> - =A0 =A0 =A0 =A0 =A0 case Timeout of
>> + =A0 =A0 =A0 =A0 =A0 case TRef of
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0no_timer -> ignore;
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0_ -> erlang:cancel_timer(TRef)
>> =A0 =A0 =A0 =A0 =A0 =A0end,
>>
>>
>> I don't know of any guidelines for patch submission since this is not
>> OTP, so let me know if there is a better way I can provide patches now
>> or in the future.
>>
>> -G
>>
>> ________________________________________________________________
>> erlang-questions (at) erlang.org mailing list.
>> See http://www.erlang.org/faq.html
>> To unsubscribe; mailto:erlang-questions-unsubscr...@erlang.org
>>
>
> Ulf Wiger, CTO, Erlang Solutions, Ltd.
> http://erlang-solutions.com
>
>
>
>
________________________________________________________________
erlang-questions (at) erlang.org mailing list.
See http://www.erlang.org/faq.html
To unsubscribe; mailto:erlang-questions-unsubscr...@erlang.org