Issue 128 in ergoemacs: ergoemacs keybinding, <menu> m can't override

39 views
Skip to first unread message

ergo...@googlecode.com

unread,
Apr 23, 2013, 6:50:13 PM4/23/13
to ergo...@googlegroups.com
Status: Accepted
Owner: xah...@gmail.com
Labels: Type-Defect Priority-Medium

New issue 128 by xah...@gmail.com: ergoemacs keybinding, <menu> m can't
override
http://code.google.com/p/ergoemacs/issues/detail?id=128

What steps will reproduce the problem?
1. put this in your emacs init
(global-set-key (kbd "<menu> m") 'nil)
(global-set-key (kbd "<menu> m c") 'calc)

2. start emacs with ergoemacs-minor mode on, after the above init.

3. the <menu> m key isn't overridden (it's still C-c C-c).

4. eval the above 2 lines of keys def again

5. now it works for most, however not in some modes.

6. open a new buffer, call sh-mode.

7. <menu> m is C-c C-c

this is latest ergoemacs-mode. Above using QWERTY notation.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

Matthew Fidler

unread,
Apr 23, 2013, 8:27:17 PM4/23/13
to ergo...@googlegroups.com

You are setting up a global prefix <menu> when ergoemacs has a local prefix <menu>.  I need a way to read any prefix keys that are defined before ergoemacs is loaded and merge them with the ergoemacs prefixes.

In addition, the advice needs to be monitored to pick up on these global changes to any prefixes that ergoemacs-mode defines.

So, I guess I need to create a function ergoemacs-is-prefix-p

Note the test suite currently verifies that a single key chord globally defined before or after ergoemacs will integrated appropriately. This is done by ignoring key definitions that are different from the emacs shipped keybindings when creating the ergoemacs map or unsetting the key in the ergoemacs map while adding it to the global map.

To support the prefix bindings, this would require a major revamping of how the keys are generated. I don't know when I'm going to get to this.

You received this message because you are subscribed to the Google Groups "ErgoEmacs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ergoemacs+unsubscribe@googlegroups.com.
To post to this group, send email to ergo...@googlegroups.com.
Visit this group at http://groups.google.com/group/ergoemacs?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Xah Lee

unread,
Apr 23, 2013, 9:05:24 PM4/23/13
to ErgoEmacs
whenever is good. No rush. Thanks Matt.


To unsubscribe from this group and stop receiving emails from it, send an email to ergoemacs+...@googlegroups.com.

Matthew Fidler

unread,
Apr 24, 2013, 1:26:29 PM4/24/13
to ergo...@googlegroups.com
Added a test case for this issue.  I don't want it coming back when its fixed.

Matthew Fidler

unread,
Apr 30, 2013, 7:30:36 PM4/30/13
to ergo...@googlegroups.com

Do you need the apps key and the menu key?

This  bug may be because ergoemacs currently doesn't play nice with the keyboard translation map.

Xah Lee

unread,
Apr 30, 2013, 7:42:43 PM4/30/13
to ErgoEmacs
i think we can scratch F6.

for app/menu key, i think it's good to have. We can add them later.

Do you use the app/menu setup?

ergo...@googlecode.com

unread,
Jun 7, 2013, 7:14:50 PM6/7/13
to ergo...@googlegroups.com

Comment #1 on issue 128 by matthew....@gmail.com: ergoemacs keybinding,
Could you try this again? I think it works.

ergo...@googlecode.com

unread,
Jun 15, 2013, 3:29:13 PM6/15/13
to ergo...@googlegroups.com
Updates:
Owner: ---

Comment #2 on issue 128 by xah...@gmail.com: ergoemacs keybinding, <menu> m
(No comment was entered for this change.)

ergo...@googlecode.com

unread,
Jun 20, 2013, 12:54:06 AM6/20/13
to ergo...@googlegroups.com

Comment #3 on issue 128 by matthew....@gmail.com: ergoemacs keybinding,
Xah, have you checked this yet. If you use global-set-key after
ergoemacs-mode loads the test succeeds. If I don't hear from you I will
close this issue.

ergo...@googlecode.com

unread,
Jun 20, 2013, 6:39:21 AM6/20/13
to ergo...@googlegroups.com

Comment #4 on issue 128 by xah...@gmail.com: ergoemacs keybinding, <menu> m
i think i did test that about 2 days ago, i've put global-set-key both
before and after turning on ergoemacs mode and also both before and after
loading ergoemacs-mode. Didn't work for me. Let me do a test again later
today.

this is supposed to work in standard layout right? (as opposed to level 3)

ergo...@googlecode.com

unread,
Jul 18, 2013, 10:41:43 AM7/18/13
to ergo...@googlegroups.com
Updates:
Status: WontFix

Comment #5 on issue 128 by matthew....@gmail.com: ergoemacs keybinding,
Moved issue to github.
Reply all
Reply to author
Forward
0 new messages